From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754584AbbHCRGW (ORCPT ); Mon, 3 Aug 2015 13:06:22 -0400 Received: from terminus.zytor.com ([198.137.202.10]:40345 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754164AbbHCRGU (ORCPT ); Mon, 3 Aug 2015 13:06:20 -0400 Date: Mon, 3 Aug 2015 10:05:40 -0700 From: tip-bot for Xunlei Pang Message-ID: Cc: juri.lelli@gmail.com, peterz@infradead.org, mingo@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, torvalds@linux-foundation.org, pang.xunlei@linaro.org, efault@gmx.de, rostedt@goodmis.org, hpa@zytor.com Reply-To: peterz@infradead.org, mingo@kernel.org, juri.lelli@gmail.com, hpa@zytor.com, rostedt@goodmis.org, efault@gmx.de, torvalds@linux-foundation.org, pang.xunlei@linaro.org, tglx@linutronix.de, linux-kernel@vger.kernel.org In-Reply-To: <1435995563-3723-1-git-send-email-xlpang@126.com> References: <1435995563-3723-1-git-send-email-xlpang@126.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:sched/core] sched/rt: Remove a redundant condition from task_woken_rt() Git-Commit-ID: 8fd373548eed815858d7b5534971bdc64b4d8d2c X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 8fd373548eed815858d7b5534971bdc64b4d8d2c Gitweb: http://git.kernel.org/tip/8fd373548eed815858d7b5534971bdc64b4d8d2c Author: Xunlei Pang AuthorDate: Sat, 4 Jul 2015 15:39:22 +0800 Committer: Ingo Molnar CommitDate: Mon, 3 Aug 2015 12:21:19 +0200 sched/rt: Remove a redundant condition from task_woken_rt() 'p' has been already queued at this point, so "!task_running(rq, p)" and "p->nr_cpus_allowed > 1" imply that "has_pushable_tasks(rq)" is true, so it can be removed. Signed-off-by: Xunlei Pang Signed-off-by: Peter Zijlstra (Intel) Acked-by: Steven Rostedt Cc: Juri Lelli Cc: Linus Torvalds Cc: Mike Galbraith Cc: Peter Zijlstra Cc: Thomas Gleixner Link: http://lkml.kernel.org/r/1435995563-3723-1-git-send-email-xlpang@126.com Signed-off-by: Ingo Molnar --- kernel/sched/rt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c index 0d193a24..00816ee 100644 --- a/kernel/sched/rt.c +++ b/kernel/sched/rt.c @@ -2069,7 +2069,6 @@ static void task_woken_rt(struct rq *rq, struct task_struct *p) { if (!task_running(rq, p) && !test_tsk_need_resched(rq->curr) && - has_pushable_tasks(rq) && p->nr_cpus_allowed > 1 && (dl_task(rq->curr) || rt_task(rq->curr)) && (rq->curr->nr_cpus_allowed < 2 ||