From: tip-bot for Viresh Kumar <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
peterz@infradead.org, viresh.kumar@linaro.org,
tglx@linutronix.de
Subject: [tip:sched/core] sched: Remove WARN_ON(!sd) from init_sched_groups_power()
Date: Wed, 19 Jun 2013 11:41:12 -0700 [thread overview]
Message-ID: <tip-94c95ba69f31e435416988ddb223c92e5b0e9e83@git.kernel.org> (raw)
In-Reply-To: <2bbe633cd74b431c05253a8ce61fdfd5066a531b.1370948150.git.viresh.kumar@linaro.org>
Commit-ID: 94c95ba69f31e435416988ddb223c92e5b0e9e83
Gitweb: http://git.kernel.org/tip/94c95ba69f31e435416988ddb223c92e5b0e9e83
Author: Viresh Kumar <viresh.kumar@linaro.org>
AuthorDate: Tue, 11 Jun 2013 16:32:45 +0530
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 19 Jun 2013 12:58:47 +0200
sched: Remove WARN_ON(!sd) from init_sched_groups_power()
sd can't be NULL in init_sched_groups_power() and so checking it for NULL isn't
useful. In case it is required, then also we need to rearrange the code a bit as
we already accessed invalid pointer sd to get sg: sg = sd->groups.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/2bbe633cd74b431c05253a8ce61fdfd5066a531b.1370948150.git.viresh.kumar@linaro.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
kernel/sched/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 014c97f..21b1403 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -5400,7 +5400,7 @@ static void init_sched_groups_power(int cpu, struct sched_domain *sd)
{
struct sched_group *sg = sd->groups;
- WARN_ON(!sd || !sg);
+ WARN_ON(!sg);
do {
sg->group_weight = cpumask_weight(sched_group_cpus(sg));
prev parent reply other threads:[~2013-06-19 18:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-11 11:02 [PATCH 0/3] sched: Sched Domains: Fixups - Part 3 Viresh Kumar
2013-06-11 11:02 ` [PATCH 1/3] sched: Use cached value of span instead of calling sched_domain_span() Viresh Kumar
2013-06-19 18:40 ` [tip:sched/core] " tip-bot for Viresh Kumar
2013-06-11 11:02 ` [PATCH 2/3] sched: don't call get_group() for covered cpus Viresh Kumar
2013-06-18 10:03 ` Peter Zijlstra
2013-06-18 10:15 ` Viresh Kumar
2013-06-18 15:19 ` Peter Zijlstra
2013-06-18 15:29 ` Viresh Kumar
2013-06-18 17:30 ` Peter Zijlstra
2013-06-19 18:41 ` [tip:sched/core] sched: Fix memory leakage in build_sched_groups( ) tip-bot for Viresh Kumar
2013-06-11 11:02 ` [PATCH 3/3] sched: remove WARN_ON(!sd) from init_sched_groups_power() Viresh Kumar
2013-06-18 10:03 ` Peter Zijlstra
2013-06-19 18:41 ` tip-bot for Viresh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-94c95ba69f31e435416988ddb223c92e5b0e9e83@git.kernel.org \
--to=tipbot@zytor.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome