From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752768AbcAFSvN (ORCPT ); Wed, 6 Jan 2016 13:51:13 -0500 Received: from terminus.zytor.com ([198.137.202.10]:54735 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752003AbcAFSvL (ORCPT ); Wed, 6 Jan 2016 13:51:11 -0500 Date: Wed, 6 Jan 2016 10:50:30 -0800 From: tip-bot for Andi Kleen Message-ID: Cc: peterz@infradead.org, acme@redhat.com, jolsa@redhat.com, linux-kernel@vger.kernel.org, eranian@google.com, mingo@kernel.org, ak@linux.intel.com, vincent.weaver@maine.edu, hpa@zytor.com, torvalds@linux-foundation.org, tglx@linutronix.de Reply-To: tglx@linutronix.de, torvalds@linux-foundation.org, hpa@zytor.com, vincent.weaver@maine.edu, ak@linux.intel.com, eranian@google.com, mingo@kernel.org, linux-kernel@vger.kernel.org, jolsa@redhat.com, acme@redhat.com, peterz@infradead.org In-Reply-To: <1449177740-5422-1-git-send-email-andi@firstfloor.org> References: <1449177740-5422-1-git-send-email-andi@firstfloor.org> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf/x86: Remove warning for zero PEBS status Git-Commit-ID: 957ea1fdbcdb909e1540f06f06f1a9ce6e696efa X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 957ea1fdbcdb909e1540f06f06f1a9ce6e696efa Gitweb: http://git.kernel.org/tip/957ea1fdbcdb909e1540f06f06f1a9ce6e696efa Author: Andi Kleen AuthorDate: Thu, 3 Dec 2015 13:22:19 -0800 Committer: Ingo Molnar CommitDate: Wed, 6 Jan 2016 11:15:30 +0100 perf/x86: Remove warning for zero PEBS status The recent commit: 75f80859b130 ("perf/x86/intel/pebs: Robustify PEBS buffer drain") causes lots of warnings on different CPUs before Skylake when running PEBS intensive workloads. They can have a zero status field in the PEBS record when PEBS is racing with clearing of GLOBAl_STATUS. This also can cause hangs (it seems there are still problems with printk in NMI). Disable the warning, but still ignore the record. Signed-off-by: Andi Kleen Signed-off-by: Peter Zijlstra (Intel) Cc: Arnaldo Carvalho de Melo Cc: Jiri Olsa Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Stephane Eranian Cc: Thomas Gleixner Cc: Vince Weaver Link: http://lkml.kernel.org/r/1449177740-5422-1-git-send-email-andi@firstfloor.org Signed-off-by: Ingo Molnar --- arch/x86/kernel/cpu/perf_event_intel_ds.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/arch/x86/kernel/cpu/perf_event_intel_ds.c b/arch/x86/kernel/cpu/perf_event_intel_ds.c index 5db1c77..0e3a9c7 100644 --- a/arch/x86/kernel/cpu/perf_event_intel_ds.c +++ b/arch/x86/kernel/cpu/perf_event_intel_ds.c @@ -1232,10 +1232,7 @@ static void intel_pmu_drain_pebs_nhm(struct pt_regs *iregs) bit = find_first_bit((unsigned long *)&pebs_status, x86_pmu.max_pebs_events); - if (WARN(bit >= x86_pmu.max_pebs_events, - "PEBS record without PEBS event! status=%Lx pebs_enabled=%Lx active_mask=%Lx", - (unsigned long long)p->status, (unsigned long long)cpuc->pebs_enabled, - *(unsigned long long *)cpuc->active_mask)) + if (bit >= x86_pmu.max_pebs_events) continue; /*