mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tip-bot for Ingo Molnar <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
	a.p.zijlstra@chello.nl, torvalds@linux-foundation.org,
	rusty@rustcorp.com.au, jwboyer@fedoraproject.org,
	akpm@linux-foundation.org, tglx@linutronix.de
Subject: [tip:core/locking] Revert "smp/cpumask: Make CONFIG_CPUMASK_OFFSTACK=y usable without debug dependency"
Date: Sat, 30 Nov 2013 06:27:23 -0800	[thread overview]
Message-ID: <tip-962d9c5757b2ebd30678a88a4f475ae997f4d5dd@git.kernel.org> (raw)

Commit-ID:  962d9c5757b2ebd30678a88a4f475ae997f4d5dd
Gitweb:     http://git.kernel.org/tip/962d9c5757b2ebd30678a88a4f475ae997f4d5dd
Author:     Ingo Molnar <mingo@kernel.org>
AuthorDate: Sat, 30 Nov 2013 15:20:15 +0100
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Sat, 30 Nov 2013 15:20:15 +0100

Revert "smp/cpumask: Make CONFIG_CPUMASK_OFFSTACK=y usable without debug dependency"

This reverts commit 9dd1220114e00d8ec5cdc20085bbe198b21e1985.

Revert it until Linus's concerns are addressed: this option should not
allow nonsensical CONFIG_CPUMASK_OFFSTACK and CONFIG_NR_CPUS values, and
it should probably select sane defaults as well.

Cc: Josh Boyer <jwboyer@fedoraproject.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/n/tip-etcruvuw9neycYf0Rripxrjv@git.kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 lib/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lib/Kconfig b/lib/Kconfig
index 3f7fb4d..06dc742 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@ -342,8 +342,7 @@ config CHECK_SIGNATURE
 	bool
 
 config CPUMASK_OFFSTACK
-	bool "Force CPU masks off stack"
-	depends on SMP
+	bool "Force CPU masks off stack" if DEBUG_PER_CPU_MAPS
 	help
 	  Use dynamic allocation for cpumask_var_t, instead of putting
 	  them on the stack.  This is a bit more expensive, but avoids

                 reply	other threads:[~2013-11-30 14:27 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-962d9c5757b2ebd30678a88a4f475ae997f4d5dd@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=hpa@zytor.com \
    --cc=jwboyer@fedoraproject.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome