mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tip-bot for Jiang Liu <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: david.vrabel@citrix.com, hpa@zytor.com, linux@eikelenboom.it,
	tony.luck@intel.com, jiang.liu@linux.intel.com, mingo@kernel.org,
	tglx@linutronix.de, lenb@kernel.org, konrad.wilk@oracle.com,
	rjw@rjwysocki.net, linux-kernel@vger.kernel.org
Subject: [tip:x86/urgent] ACPI: pci: Do not clear pci_dev-> irq in acpi_pci_irq_disable()
Date: Tue, 20 Jan 2015 02:49:44 -0800	[thread overview]
Message-ID: <tip-9889eaeb7c999cae64006bb98c47f40f412ec875@git.kernel.org> (raw)
In-Reply-To: <1421720467-7709-3-git-send-email-jiang.liu@linux.intel.com>

Commit-ID:  9889eaeb7c999cae64006bb98c47f40f412ec875
Gitweb:     http://git.kernel.org/tip/9889eaeb7c999cae64006bb98c47f40f412ec875
Author:     Jiang Liu <jiang.liu@linux.intel.com>
AuthorDate: Tue, 20 Jan 2015 10:21:06 +0800
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Tue, 20 Jan 2015 11:44:40 +0100

ACPI: pci: Do not clear pci_dev->irq in acpi_pci_irq_disable()

Xen pciback driver assumes that pci_dev->irq won't change after calling
pci_disable_device(). But commit cffe0a2b5a34c95a4dadc9ec7132690a5b0f6687
("x86, irq: Keep balance of IOAPIC pin reference count") frees irq
resources and resets pci_dev->irq to zero when pci_disable_device() is
called.

So this is a hotfix for 3.19 to avoid resetting pci_dev->irq, and
another proper fix will be prepared for next merging window.

Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
Tested-by: Sander Eikelenboom <linux@eikelenboom.it>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: David Vrabel <david.vrabel@citrix.com>
Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
Cc: Len Brown <lenb@kernel.org>
Link: http://lkml.kernel.org/r/1421720467-7709-3-git-send-email-jiang.liu@linux.intel.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 drivers/acpi/pci_irq.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/acpi/pci_irq.c b/drivers/acpi/pci_irq.c
index 5277a0e..b1def41 100644
--- a/drivers/acpi/pci_irq.c
+++ b/drivers/acpi/pci_irq.c
@@ -512,7 +512,6 @@ void acpi_pci_irq_disable(struct pci_dev *dev)
 	dev_dbg(&dev->dev, "PCI INT %c disabled\n", pin_name(pin));
 	if (gsi >= 0) {
 		acpi_unregister_gsi(gsi);
-		dev->irq = 0;
 		dev->irq_managed = 0;
 	}
 }

  reply	other threads:[~2015-01-20 10:50 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-20  2:21 [Bugfix 0/3] Xen IRQ related hotfixes for v3.19 Jiang Liu
2015-01-20  2:21 ` [Bugfix 1/3] xen/pci: Kill function xen_setup_acpi_sci() Jiang Liu
2015-01-20  9:54   ` David Vrabel
2015-01-20 10:49   ` [tip:x86/urgent] x86/xen: Treat SCI interrupt as normal GSI interrupt tip-bot for Jiang Liu
2015-01-20  2:21 ` [Bugfix 2/3] xen/irq, ACPI: Fix regression in xen PCI passthrough caused by cffe0a2b5a34 Jiang Liu
2015-01-20 10:49   ` tip-bot for Jiang Liu [this message]
2015-01-20  2:21 ` [Bugfix 3/3] xen/irq: Override ACPI IRQ management callback __acpi_unregister_gsi Jiang Liu
2015-01-20  9:56   ` David Vrabel
2015-01-20 10:50   ` [tip:x86/urgent] x86/xen: " tip-bot for Jiang Liu
2015-02-05 20:07 ` [Bugfix 0/3] Xen IRQ related hotfixes for v3.19 Sander Eikelenboom
2015-02-09  9:47   ` Stefan Bader
2015-02-09 12:12     ` Jiang Liu
2015-02-09 12:29       ` Stefan Bader
2015-02-09 16:09         ` Stefan Bader
2015-02-09 16:55           ` Sander Eikelenboom
2015-02-09 19:15           ` Sander Eikelenboom
2015-02-10 13:31             ` Stefan Bader
2015-02-09 12:17     ` Sander Eikelenboom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-9889eaeb7c999cae64006bb98c47f40f412ec875@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=david.vrabel@citrix.com \
    --cc=hpa@zytor.com \
    --cc=jiang.liu@linux.intel.com \
    --cc=konrad.wilk@oracle.com \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=linux@eikelenboom.it \
    --cc=mingo@kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome