From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752367AbbCAItn (ORCPT ); Sun, 1 Mar 2015 03:49:43 -0500 Received: from terminus.zytor.com ([198.137.202.10]:53913 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751000AbbCAIti (ORCPT ); Sun, 1 Mar 2015 03:49:38 -0500 Date: Sun, 1 Mar 2015 00:48:42 -0800 From: tip-bot for Sebastian Andrzej Siewior Message-ID: Cc: tglx@linutronix.de, hpa@zytor.com, umgwanakikbuti@gmail.com, torvalds@linux-foundation.org, maarten.lankhorst@canonical.com, peterz@infradead.org, mingo@kernel.org, linux-kernel@vger.kernel.org, bigeasy@linutronix.de Reply-To: linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@kernel.org, maarten.lankhorst@canonical.com, torvalds@linux-foundation.org, umgwanakikbuti@gmail.com, bigeasy@linutronix.de, hpa@zytor.com, tglx@linutronix.de In-Reply-To: <1425056229-22326-4-git-send-email-bigeasy@linutronix.de> References: <1425056229-22326-4-git-send-email-bigeasy@linutronix.de> To: linux-tip-commits@vger.kernel.org Subject: [tip:locking/urgent] locking/rtmutex: Set state back to running on error Git-Commit-ID: 9d3e2d02f54160725d97f4ab1e1e8de493fbf33a X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 9d3e2d02f54160725d97f4ab1e1e8de493fbf33a Gitweb: http://git.kernel.org/tip/9d3e2d02f54160725d97f4ab1e1e8de493fbf33a Author: Sebastian Andrzej Siewior AuthorDate: Fri, 27 Feb 2015 17:57:09 +0100 Committer: Ingo Molnar CommitDate: Sun, 1 Mar 2015 09:45:06 +0100 locking/rtmutex: Set state back to running on error The "usual" path is: - rt_mutex_slowlock() - set_current_state() - task_blocks_on_rt_mutex() (ret 0) - __rt_mutex_slowlock() - sleep or not but do return with __set_current_state(TASK_RUNNING) - back to caller. In the early error case where task_blocks_on_rt_mutex() return -EDEADLK we never change the task's state back to RUNNING. I assume this is intended. Without this change after ww_mutex using rt_mutex the selftest passes but later I get plenty of: | bad: scheduling from the idle thread! backtraces. Signed-off-by: Sebastian Andrzej Siewior Acked-by: Mike Galbraith Cc: Linus Torvalds Cc: Maarten Lankhorst Cc: Peter Zijlstra Cc: Thomas Gleixner Fixes: afffc6c1805d ("locking/rtmutex: Optimize setting task running after being blocked") Link: http://lkml.kernel.org/r/1425056229-22326-4-git-send-email-bigeasy@linutronix.de Signed-off-by: Ingo Molnar --- kernel/locking/rtmutex.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/locking/rtmutex.c b/kernel/locking/rtmutex.c index e16e554..6357265 100644 --- a/kernel/locking/rtmutex.c +++ b/kernel/locking/rtmutex.c @@ -1193,6 +1193,7 @@ rt_mutex_slowlock(struct rt_mutex *lock, int state, ret = __rt_mutex_slowlock(lock, state, timeout, &waiter); if (unlikely(ret)) { + __set_current_state(TASK_RUNNING); if (rt_mutex_has_waiters(lock)) remove_waiter(lock, &waiter); rt_mutex_handle_deadlock(ret, chwalk, &waiter);