mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tip-bot for Randy Dunlap <randy.dunlap@oracle.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
	dsd@laptop.org, sfr@canb.auug.org.au, tglx@linutronix.de,
	randy.dunlap@oracle.com, mingo@elte.hu
Subject: [tip:x86/olpc] x86, olpc: XO-1 uses/depends on PCI
Date: Fri, 15 Oct 2010 07:46:54 GMT	[thread overview]
Message-ID: <tip-9e9006e9090dc1f88d5127cb69f416013e7ecd60@git.kernel.org> (raw)
In-Reply-To: <20101014101313.adf7eb2a.randy.dunlap@oracle.com>

Commit-ID:  9e9006e9090dc1f88d5127cb69f416013e7ecd60
Gitweb:     http://git.kernel.org/tip/9e9006e9090dc1f88d5127cb69f416013e7ecd60
Author:     Randy Dunlap <randy.dunlap@oracle.com>
AuthorDate: Thu, 14 Oct 2010 10:13:13 -0700
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Fri, 15 Oct 2010 09:41:38 +0200

x86, olpc: XO-1 uses/depends on PCI

olpc-xo1 uses pci_*() interfaces so it should depend on PCI.

Otherwise we get build failure like:

 arch/x86/kernel/olpc-xo1.c:65: error: implicit declaration of function 'pci_enable_device_io'
 arch/x86/kernel/olpc-xo1.c:71: error: implicit declaration of function 'pci_request_region'
 arch/x86/kernel/olpc-xo1.c:80: error: implicit declaration of function 'pci_release_region'

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Acked-by: Daniel Drake <dsd@laptop.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
LKML-Reference: <20101014101313.adf7eb2a.randy.dunlap@oracle.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/x86/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 0bcb876..c010b8d 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -2068,7 +2068,7 @@ config OLPC
 
 config OLPC_XO1
 	tristate "OLPC XO-1 support"
-	depends on OLPC
+	depends on OLPC && PCI
 	---help---
 	  Add support for non-essential features of the OLPC XO-1 laptop.
 

      reply	other threads:[~2010-10-15  7:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-14  4:26 linux-next: Tree for October 14 Stephen Rothwell
2010-10-14 17:13 ` [PATCH -next] x86: olpc-xo1 uses/depends on PCI Randy Dunlap
2010-10-15  7:46   ` tip-bot for Randy Dunlap [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-9e9006e9090dc1f88d5127cb69f416013e7ecd60@git.kernel.org \
    --to=randy.dunlap@oracle.com \
    --cc=dsd@laptop.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=sfr@canb.auug.org.au \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome