From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756968AbbEEIkq (ORCPT ); Tue, 5 May 2015 04:40:46 -0400 Received: from terminus.zytor.com ([198.137.202.10]:47897 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756927AbbEEIkl (ORCPT ); Tue, 5 May 2015 04:40:41 -0400 Date: Tue, 5 May 2015 01:40:28 -0700 From: tip-bot for Maxime Ripard Message-ID: Cc: mingo@kernel.org, linux-kernel@vger.kernel.org, maxime.ripard@free-electrons.com, hpa@zytor.com, daniel.lezcano@linaro.org, tglx@linutronix.de Reply-To: mingo@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org, maxime.ripard@free-electrons.com, daniel.lezcano@linaro.org, tglx@linutronix.de In-Reply-To: <1430579006-32702-6-git-send-email-maxime.ripard@free-electrons.com> References: <1430579006-32702-6-git-send-email-maxime.ripard@free-electrons.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:timers/core] clocksource: sun5i: Fix of_io_request_and_map error check Git-Commit-ID: 9fa8cc0a85c774b75218ba5f385792be387c190b X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 9fa8cc0a85c774b75218ba5f385792be387c190b Gitweb: http://git.kernel.org/tip/9fa8cc0a85c774b75218ba5f385792be387c190b Author: Maxime Ripard AuthorDate: Sat, 2 May 2015 17:03:25 +0200 Committer: Thomas Gleixner CommitDate: Tue, 5 May 2015 10:35:58 +0200 clocksource: sun5i: Fix of_io_request_and_map error check of_io_request_and map returns an error pointer, but the current code assumes that on error the returned pointer will be NULL. Obviously, that makes the check completely useless. Change the test to actually check for the proper error code. Signed-off-by: Maxime Ripard Cc: Daniel Lezcano Link: http://lkml.kernel.org/r/1430579006-32702-6-git-send-email-maxime.ripard@free-electrons.com Signed-off-by: Thomas Gleixner --- drivers/clocksource/timer-sun5i.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clocksource/timer-sun5i.c b/drivers/clocksource/timer-sun5i.c index 28aa4b7..0ffb4ea 100644 --- a/drivers/clocksource/timer-sun5i.c +++ b/drivers/clocksource/timer-sun5i.c @@ -324,7 +324,7 @@ static void __init sun5i_timer_init(struct device_node *node) int irq; timer_base = of_io_request_and_map(node, 0, of_node_full_name(node)); - if (!timer_base) + if (IS_ERR(timer_base)) panic("Can't map registers"); irq = irq_of_parse_and_map(node, 0);