mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tip-bot for Yisheng Xie <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, alexander.shishkin@linux.intel.com,
	jolsa@redhat.com, namhyung@kernel.org, mingo@kernel.org,
	hpa@zytor.com, tglx@linutronix.de, kan.liang@linux.intel.com,
	acme@redhat.com, xieyisheng1@huawei.com, peterz@infradead.org
Subject: [tip:perf/core] perf debug: Avoid setting 'quiet' to 'true' unnecessarily
Date: Mon, 19 Mar 2018 23:33:58 -0700	[thread overview]
Message-ID: <tip-a08f6dd4190e90dc7b013435acb66770f117e8b0@git.kernel.org> (raw)
In-Reply-To: <1520944274-37001-2-git-send-email-xieyisheng1@huawei.com>

Commit-ID:  a08f6dd4190e90dc7b013435acb66770f117e8b0
Gitweb:     https://git.kernel.org/tip/a08f6dd4190e90dc7b013435acb66770f117e8b0
Author:     Yisheng Xie <xieyisheng1@huawei.com>
AuthorDate: Tue, 13 Mar 2018 20:31:14 +0800
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Fri, 16 Mar 2018 16:39:02 -0300

perf debug: Avoid setting 'quiet' to 'true' unnecessarily

When using --quiet to disable messages, we will set the 'quiet' variable
to 'true' first, then check that variable to decide whether we need to
call perf_quiet_option(), so no need to set 'quiet' to 'true' once more
in perf_quiet_option().

Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1520944274-37001-2-git-send-email-xieyisheng1@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/debug.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/perf/util/debug.c b/tools/perf/util/debug.c
index f3a71db83947..3d6459626c2a 100644
--- a/tools/perf/util/debug.c
+++ b/tools/perf/util/debug.c
@@ -232,7 +232,6 @@ int perf_quiet_option(void)
 		var++;
 	}
 
-	quiet = true;
 	return 0;
 }
 

  reply	other threads:[~2018-03-20  6:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-13 12:31 [PATCH v2 -perf/core 1/2] perf mmap: Discard head in overwrite_rb_find_range Yisheng Xie
2018-03-13 12:31 ` [PATCH v2 -perf/core 2/2] perf debug: Avoid set quiet once more Yisheng Xie
2018-03-20  6:33   ` tip-bot for Yisheng Xie [this message]
2018-03-16 14:16 ` [PATCH v2 -perf/core 1/2] perf mmap: Discard head in overwrite_rb_find_range Liang, Kan
2018-03-20  6:33 ` [tip:perf/core] perf mmap: Discard head in overwrite_rb_find_range() tip-bot for Yisheng Xie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-a08f6dd4190e90dc7b013435acb66770f117e8b0@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=acme@redhat.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=jolsa@redhat.com \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=xieyisheng1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome