From: tip-bot for Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: linux-tip-commits@vger.kernel.org
Cc: acme@redhat.com, linux-kernel@vger.kernel.org, hpa@zytor.com,
mingo@kernel.org, torvalds@linux-foundation.org,
peterz@infradead.org, ananth@in.ibm.com, anton@redhat.com,
masami.hiramatsu.pt@hitachi.com, rostedt@goodmis.org,
acme@infradead.org, srikar@linux.vnet.ibm.com, oleg@redhat.com,
tglx@linutronix.de
Subject: [tip:perf/urgent] perf uprobes: Remove unnecessary check before strlist__delete
Date: Wed, 6 Jun 2012 00:08:45 -0700 [thread overview]
Message-ID: <tip-a23c4dc422cff7bd30f40f5dc7c9ac4a6339005a@git.kernel.org> (raw)
In-Reply-To: <20120531114643.23691.38666.sendpatchset@srdronam.in.ibm.com>
Commit-ID: a23c4dc422cff7bd30f40f5dc7c9ac4a6339005a
Gitweb: http://git.kernel.org/tip/a23c4dc422cff7bd30f40f5dc7c9ac4a6339005a
Author: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
AuthorDate: Thu, 31 May 2012 17:16:43 +0530
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Thu, 31 May 2012 12:08:49 -0300
perf uprobes: Remove unnecessary check before strlist__delete
Since strlist__delete() itself checks, the additional check before
calling strlist__delete() is redundant.
No Functional change.
Signed-off-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Suggested-by: Arnaldo Carvalho de Melo <acme@infradead.org>
Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Cc: Anton Arapov <anton@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Link: http://lkml.kernel.org/r/20120531114643.23691.38666.sendpatchset@srdronam.in.ibm.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/probe-event.c | 8 ++------
1 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
index 59dccc9..0dda25d 100644
--- a/tools/perf/util/probe-event.c
+++ b/tools/perf/util/probe-event.c
@@ -2164,16 +2164,12 @@ int del_perf_probe_events(struct strlist *dellist)
error:
if (kfd >= 0) {
- if (namelist)
- strlist__delete(namelist);
-
+ strlist__delete(namelist);
close(kfd);
}
if (ufd >= 0) {
- if (unamelist)
- strlist__delete(unamelist);
-
+ strlist__delete(unamelist);
close(ufd);
}
next prev parent reply other threads:[~2012-06-06 7:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-31 11:46 [PATCH 1/3] uprobes/core: Remove redundant lock_page/unlock_page Srikar Dronamraju
2012-05-31 11:46 ` [PATCH 2/3] perf/uprobes: Remove unnecessary check before strlist__delete Srikar Dronamraju
2012-06-06 7:08 ` tip-bot for Srikar Dronamraju [this message]
2012-05-31 11:46 ` [PATCH 3/3] perf: Check for valid dso before creating map Srikar Dronamraju
2012-06-06 7:07 ` [tip:perf/urgent] perf symbols: " tip-bot for Srikar Dronamraju
2012-05-31 11:58 ` [PATCH 1/3] uprobes/core: Remove redundant lock_page/unlock_page Peter Zijlstra
2012-05-31 14:22 ` Steven Rostedt
2012-05-31 15:07 ` Srikar Dronamraju
2012-05-31 16:56 ` Peter Zijlstra
2012-05-31 16:58 ` Srikar Dronamraju
2012-06-01 9:19 ` [RESEND PATCH 1/3] uprobes: " Srikar Dronamraju
2012-06-01 18:52 ` Oleg Nesterov
2012-06-06 9:18 ` Ingo Molnar
2012-06-06 9:19 ` Peter Zijlstra
2012-08-06 11:57 ` Anton Arapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-a23c4dc422cff7bd30f40f5dc7c9ac4a6339005a@git.kernel.org \
--to=srikar@linux.vnet.ibm.com \
--cc=acme@infradead.org \
--cc=acme@redhat.com \
--cc=ananth@in.ibm.com \
--cc=anton@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome