mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tip-bot for Namhyung Kim <namhyung@gmail.com>
To: linux-tip-commits@vger.kernel.org
Cc: acme@redhat.com, eranian@google.com, mingo@kernel.org,
	peterz@infradead.org, efault@gmx.de, namhyung.kim@lge.com,
	fweisbec@gmail.com, dsahern@gmail.com, tglx@linutronix.de,
	hpa@zytor.com, paulus@samba.org, linux-kernel@vger.kernel.org,
	andi@firstfloor.org, ashay.rane@tacc.utexas.edu,
	namhyung@gmail.com, masami.hiramatsu.pt@hitachi.com
Subject: [tip:perf/core] perf annotate: Fix a build error
Date: Fri, 13 Apr 2012 11:19:38 -0700	[thread overview]
Message-ID: <tip-a31b7cc083b1d3d15bd475729fc4471685ebc5f6@git.kernel.org> (raw)
In-Reply-To: <87ty0tlv4i.fsf@dasan.aot.lge.com>

Commit-ID:  a31b7cc083b1d3d15bd475729fc4471685ebc5f6
Gitweb:     http://git.kernel.org/tip/a31b7cc083b1d3d15bd475729fc4471685ebc5f6
Author:     Namhyung Kim <namhyung@gmail.com>
AuthorDate: Wed, 11 Apr 2012 17:04:59 -0300
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Wed, 11 Apr 2012 17:07:18 -0300

perf annotate: Fix a build error

    CC util/annotate.o
util/annotate.c: In function symbol__annotate:
util/annotate.c:87:16: error: parsed_line may be used uninitialized in this function [-Werror=maybe-uninitialized]
util/annotate.c:211:22: note: parsed_line was declared here
cc1: all warnings being treated as errors
make: *** [util/annotate.o] Error 1
make: *** Waiting for unfinished jobs....

Signed-off-by: Namhyung Kim <namhyung.kim@lge.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: Ashay Rane <ashay.rane@tacc.utexas.edu>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/87ty0tlv4i.fsf@dasan.aot.lge.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/annotate.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index 9fc4126..1e7fd52 100644
--- a/tools/perf/util/annotate.c
+++ b/tools/perf/util/annotate.c
@@ -226,6 +226,7 @@ static int symbol__parse_objdump_line(struct symbol *sym, struct map *map,
 		*c = 0;
 
 	line_ip = -1;
+	parsed_line = line;
 
 	/*
 	 * Strip leading spaces:
@@ -255,8 +256,7 @@ static int symbol__parse_objdump_line(struct symbol *sym, struct map *map,
 			offset = -1;
 		else
 			parsed_line = tmp2 + 1;
-	} else
-		parsed_line = line;
+	}
 
 	objdump_line = objdump_line__new(offset, parsed_line, privsize);
 	free(line);

      reply	other threads:[~2012-04-13 18:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-07 20:54 [GIT PULL 0/8] perf/urgent new features Arnaldo Carvalho de Melo
2012-04-07 20:54 ` [PATCH 1/8] perf ui browser: Return the current color when setting a new one Arnaldo Carvalho de Melo
2012-04-07 20:54 ` [PATCH 2/8] perf annotate: Allow printing objdump line addr in different color Arnaldo Carvalho de Melo
2012-04-07 20:54 ` [PATCH 3/8] perf ui annotate browser: Allow toggling addr offset view Arnaldo Carvalho de Melo
2012-04-07 20:54 ` [PATCH 4/8] perf ui annotate browser: Move callq handling to separate function Arnaldo Carvalho de Melo
2012-04-07 20:54 ` [PATCH 5/8] perf ui annotate browser: Add list based search for addr offset Arnaldo Carvalho de Melo
2012-04-07 20:54 ` [PATCH 6/8] perf annotate browser: Initial support for navigating jump instructions Arnaldo Carvalho de Melo
2012-04-09  2:02   ` David Ahern
2012-04-07 20:54 ` [PATCH 7/8] perf report: Correct display of samples and events in header Arnaldo Carvalho de Melo
2012-04-07 20:54 ` [PATCH 8/8] perf annotate browser: string search: /?n Arnaldo Carvalho de Melo
2012-04-08 22:24 ` [GIT PULL 0/8] perf/urgent new features Namhyung Kim
2012-04-13 18:19   ` tip-bot for Namhyung Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-a31b7cc083b1d3d15bd475729fc4471685ebc5f6@git.kernel.org \
    --to=namhyung@gmail.com \
    --cc=acme@redhat.com \
    --cc=andi@firstfloor.org \
    --cc=ashay.rane@tacc.utexas.edu \
    --cc=dsahern@gmail.com \
    --cc=efault@gmx.de \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mingo@kernel.org \
    --cc=namhyung.kim@lge.com \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome