From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753232AbbL2Kqm (ORCPT ); Tue, 29 Dec 2015 05:46:42 -0500 Received: from terminus.zytor.com ([198.137.202.10]:57053 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753087AbbL2Kqi (ORCPT ); Tue, 29 Dec 2015 05:46:38 -0500 Date: Tue, 29 Dec 2015 02:46:23 -0800 From: tip-bot for Andrea Merello Message-ID: Cc: marc.zyngier@arm.com, andrea.merello@gmail.com, swarren@wwwdotorg.org, tglx@linutronix.de, mingo@kernel.org, linux-kernel@vger.kernel.org, hpa@zytor.com, lee@kernel.org, eric@anholt.net, f.fainelli@gmail.com, jason@lakedaemon.net Reply-To: f.fainelli@gmail.com, jason@lakedaemon.net, lee@kernel.org, eric@anholt.net, hpa@zytor.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@kernel.org, andrea.merello@gmail.com, swarren@wwwdotorg.org, marc.zyngier@arm.com In-Reply-To: <1451166444-11044-4-git-send-email-eric@anholt.net> References: <1451166444-11044-4-git-send-email-eric@anholt.net> To: linux-tip-commits@vger.kernel.org Subject: [tip:irq/core] irqchip/bcm2836: Tolerate IRQs while no flag is set in ISR Git-Commit-ID: a51744ddcc62925ec4d3d3d3a8a13bdd2033af59 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: a51744ddcc62925ec4d3d3d3a8a13bdd2033af59 Gitweb: http://git.kernel.org/tip/a51744ddcc62925ec4d3d3d3a8a13bdd2033af59 Author: Andrea Merello AuthorDate: Sat, 26 Dec 2015 13:47:23 -0800 Committer: Thomas Gleixner CommitDate: Tue, 29 Dec 2015 11:40:45 +0100 irqchip/bcm2836: Tolerate IRQs while no flag is set in ISR On my RPi2 I got a lot of: unexpected IRQ trap at vector 00 This happens because bcm2836_arm_irqchip_handle_irq() is sometimes invoked even if the ISR is clear, and this case is not handled. This patch explicitly handle this case, fixing the kernel complaints about the bad IRQ lookup. Signed-off-by: Andrea Merello Reviewed-by: Eric Anholt Signed-off-by: Eric Anholt Cc: linux-arm-kernel@lists.infradead.org Cc: Stephen Warren Cc: Lee Jones Cc: Florian Fainelli Cc: Jason Cooper Cc: Marc Zyngier Cc: linux-rpi-kernel@lists.infradead.org Link: http://lkml.kernel.org/r/1451166444-11044-4-git-send-email-eric@anholt.net Signed-off-by: Thomas Gleixner --- drivers/irqchip/irq-bcm2836.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-bcm2836.c b/drivers/irqchip/irq-bcm2836.c index 59ac40c..bb8f234 100644 --- a/drivers/irqchip/irq-bcm2836.c +++ b/drivers/irqchip/irq-bcm2836.c @@ -177,7 +177,7 @@ __exception_irq_entry bcm2836_arm_irqchip_handle_irq(struct pt_regs *regs) writel(1 << ipi, mailbox0); handle_IPI(ipi, regs); #endif - } else { + } else if (stat) { u32 hwirq = ffs(stat) - 1; handle_IRQ(irq_linear_revmap(intc.domain, hwirq), regs);