From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754655AbbCCGYe (ORCPT ); Tue, 3 Mar 2015 01:24:34 -0500 Received: from terminus.zytor.com ([198.137.202.10]:49265 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751536AbbCCGYc (ORCPT ); Tue, 3 Mar 2015 01:24:32 -0500 Date: Mon, 2 Mar 2015 22:24:02 -0800 From: tip-bot for Ingo Molnar Message-ID: Cc: jolsa@redhat.com, mingo@kernel.org, linux-kernel@vger.kernel.org, namhyung@kernel.org, peterz@infradead.org, tglx@linutronix.de, david.ahern@oracle.com, acme@redhat.com, hpa@zytor.com Reply-To: linux-kernel@vger.kernel.org, mingo@kernel.org, namhyung@kernel.org, jolsa@redhat.com, tglx@linutronix.de, peterz@infradead.org, david.ahern@oracle.com, acme@redhat.com, hpa@zytor.com In-Reply-To: <20150228081750.GA31887@gmail.com> References: <20150228081750.GA31887@gmail.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf tools: Remove annoying extra message from the features build Git-Commit-ID: a6a76ba9ea03fe22eb28a6a19482d547b8773001 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: a6a76ba9ea03fe22eb28a6a19482d547b8773001 Gitweb: http://git.kernel.org/tip/a6a76ba9ea03fe22eb28a6a19482d547b8773001 Author: Ingo Molnar AuthorDate: Sat, 28 Feb 2015 09:17:50 +0100 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 2 Mar 2015 12:07:35 -0300 perf tools: Remove annoying extra message from the features build This message: Makefile:153: The path 'python-config' is not executable. Appears on every perf build that does not have a sufficient python environment installed. It's really just an internal detail of python configuration pass and users should not see it - and it's pretty meaningless to them in any case because the message is not very helpful. (So it's not executable. Why does that matter? What can the user do about it?) Remove the warning, the missing python feature warning is sufficient: config/Makefile:566: No python-config tool was found config/Makefile:566: Python support will not be built although even that one isn't very helpful to users: so no Python support will be built, what can the user do to fix that? Most other such warnings give package install suggestions. Signed-off-by: Ingo Molnar Cc: David Ahern Cc: Jiri Olsa Cc: Namhyung Kim Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/20150228081750.GA31887@gmail.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/config/utilities.mak | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/perf/config/utilities.mak b/tools/perf/config/utilities.mak index 7076a62..c16ce83 100644 --- a/tools/perf/config/utilities.mak +++ b/tools/perf/config/utilities.mak @@ -175,6 +175,5 @@ _ge-abspath = $(if $(is-executable),$(1)) define get-executable-or-default $(if $($(1)),$(call _ge_attempt,$($(1)),$(1)),$(call _ge_attempt,$(2))) endef -_ge_attempt = $(if $(get-executable),$(get-executable),$(_gea_warn)$(call _gea_err,$(2))) -_gea_warn = $(warning The path '$(1)' is not executable.) +_ge_attempt = $(if $(get-executable),$(get-executable),$(call _gea_err,$(2))) _gea_err = $(if $(1),$(error Please set '$(1)' appropriately))