From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750827AbdAWIDF (ORCPT ); Mon, 23 Jan 2017 03:03:05 -0500 Received: from terminus.zytor.com ([65.50.211.136]:60916 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750712AbdAWIDE (ORCPT ); Mon, 23 Jan 2017 03:03:04 -0500 Date: Mon, 23 Jan 2017 00:01:22 -0800 From: tip-bot for Xunlei Pang Message-ID: Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, robert@leblancnet.us, xlpang@redhat.com, hpa@zytor.com, bhe@redhat.com, bp@alien8.de, torvalds@linux-foundation.org, mingo@kernel.org, akpm@linux-foundation.org, tglx@linutronix.de, dyoung@redhat.com Reply-To: dyoung@redhat.com, mingo@kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, tglx@linutronix.de, bhe@redhat.com, hpa@zytor.com, bp@alien8.de, peterz@infradead.org, linux-kernel@vger.kernel.org, xlpang@redhat.com, robert@leblancnet.us In-Reply-To: <1485154103-18426-1-git-send-email-xlpang@redhat.com> References: <1485154103-18426-1-git-send-email-xlpang@redhat.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/debug] x86/crash: Update the stale comment in reserve_crashkernel() Git-Commit-ID: a8d4c8246b290ce97f88752d833804843041ac84 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: a8d4c8246b290ce97f88752d833804843041ac84 Gitweb: http://git.kernel.org/tip/a8d4c8246b290ce97f88752d833804843041ac84 Author: Xunlei Pang AuthorDate: Mon, 23 Jan 2017 14:48:23 +0800 Committer: Ingo Molnar CommitDate: Mon, 23 Jan 2017 08:57:55 +0100 x86/crash: Update the stale comment in reserve_crashkernel() CRASH_KERNEL_ADDR_MAX has been missing for a long time, update it with a more detailed explanation. Signed-off-by: Xunlei Pang Cc: Andrew Morton Cc: Baoquan He Cc: Borislav Petkov Cc: Dave Young Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Robert LeBlanc Cc: Thomas Gleixner Cc: kexec@lists.infradead.org Link: http://lkml.kernel.org/r/1485154103-18426-1-git-send-email-xlpang@redhat.com Signed-off-by: Ingo Molnar --- arch/x86/kernel/setup.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c index 4cfba94..eb69b14 100644 --- a/arch/x86/kernel/setup.c +++ b/arch/x86/kernel/setup.c @@ -575,7 +575,9 @@ static void __init reserve_crashkernel(void) /* 0 means: find the address automatically */ if (crash_base <= 0) { /* - * kexec want bzImage is below CRASH_KERNEL_ADDR_MAX + * Set CRASH_ADDR_LOW_MAX upper bound for crash memory, + * as old kexec-tools loads bzImage below that, unless + * "crashkernel=size[KMG],high" is specified. */ crash_base = memblock_find_in_range(CRASH_ALIGN, high ? CRASH_ADDR_HIGH_MAX