From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754046AbdKAIvg (ORCPT ); Wed, 1 Nov 2017 04:51:36 -0400 Received: from terminus.zytor.com ([65.50.211.136]:49893 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752009AbdKAIvd (ORCPT ); Wed, 1 Nov 2017 04:51:33 -0400 Date: Wed, 1 Nov 2017 01:45:55 -0700 From: tip-bot for Matthias Kaehlcke Message-ID: Cc: groeck@chromium.org, mka@chromium.org, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, mingo@kernel.org, nick.desaulniers@gmail.com, tglx@linutronix.de, dianders@chromium.org, shile.zhang@nokia.com, peterz@infradead.org, hpa@zytor.com Reply-To: dianders@chromium.org, shile.zhang@nokia.com, hpa@zytor.com, peterz@infradead.org, groeck@chromium.org, mka@chromium.org, mingo@kernel.org, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, nick.desaulniers@gmail.com In-Reply-To: <20171030180816.170850-1-mka@chromium.org> References: <20171030180816.170850-1-mka@chromium.org> To: linux-tip-commits@vger.kernel.org Subject: [tip:sched/core] sched/sysctl: Fix attributes of some extern declarations Git-Commit-ID: a9903f04e0a4ea522d959c2f287cdf0ab029e324 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: a9903f04e0a4ea522d959c2f287cdf0ab029e324 Gitweb: https://git.kernel.org/tip/a9903f04e0a4ea522d959c2f287cdf0ab029e324 Author: Matthias Kaehlcke AuthorDate: Mon, 30 Oct 2017 11:08:16 -0700 Committer: Ingo Molnar CommitDate: Wed, 1 Nov 2017 09:36:17 +0100 sched/sysctl: Fix attributes of some extern declarations The definition of sysctl_sched_migration_cost, sysctl_sched_nr_migrate and sysctl_sched_time_avg includes the attribute const_debug. This attribute is not part of the extern declaration of these variables in include/linux/sched/sysctl.h, while it is in kernel/sched/sched.h, and as a result Clang generates warnings like this: kernel/sched/sched.h:1618:33: warning: section attribute is specified on redeclared variable [-Wsection] extern const_debug unsigned int sysctl_sched_time_avg; ^ ./include/linux/sched/sysctl.h:42:21: note: previous declaration is here extern unsigned int sysctl_sched_time_avg; The header only declares the variables when CONFIG_SCHED_DEBUG is defined, therefore it is not necessary to duplicate the definition of const_debug. Instead we can use the attribute __read_mostly, which is the expansion of const_debug when CONFIG_SCHED_DEBUG=y is set. Signed-off-by: Matthias Kaehlcke Reviewed-by: Nick Desaulniers Cc: Douglas Anderson Cc: Guenter Roeck Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Shile Zhang Cc: Thomas Gleixner Link: http://lkml.kernel.org/r/20171030180816.170850-1-mka@chromium.org Signed-off-by: Ingo Molnar --- include/linux/sched/sysctl.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/linux/sched/sysctl.h b/include/linux/sched/sysctl.h index 0f5ecd4..d34c823 100644 --- a/include/linux/sched/sysctl.h +++ b/include/linux/sched/sysctl.h @@ -37,9 +37,9 @@ extern unsigned int sysctl_numa_balancing_scan_period_max; extern unsigned int sysctl_numa_balancing_scan_size; #ifdef CONFIG_SCHED_DEBUG -extern unsigned int sysctl_sched_migration_cost; -extern unsigned int sysctl_sched_nr_migrate; -extern unsigned int sysctl_sched_time_avg; +extern __read_mostly unsigned int sysctl_sched_migration_cost; +extern __read_mostly unsigned int sysctl_sched_nr_migrate; +extern __read_mostly unsigned int sysctl_sched_time_avg; int sched_proc_update_handler(struct ctl_table *table, int write, void __user *buffer, size_t *length,