mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tip-bot for Vasyl Gomonovych <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: hpa@zytor.com, mingo@kernel.org, linux-kernel@vger.kernel.org,
	tglx@linutronix.de, gomonovych@gmail.com
Subject: [tip:irq/urgent] irqchoip/imgpdc: Use resource_size function on resource object
Date: Thu, 23 Nov 2017 11:10:27 -0800	[thread overview]
Message-ID: <tip-a994988d73db142fbe842ce08bbda62b12456577@git.kernel.org> (raw)
In-Reply-To: <1511215361-8279-1-git-send-email-gomonovych@gmail.com>

Commit-ID:  a994988d73db142fbe842ce08bbda62b12456577
Gitweb:     https://git.kernel.org/tip/a994988d73db142fbe842ce08bbda62b12456577
Author:     Vasyl Gomonovych <gomonovych@gmail.com>
AuthorDate: Mon, 20 Nov 2017 23:02:41 +0100
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Thu, 23 Nov 2017 20:04:55 +0100

irqchoip/imgpdc: Use resource_size function on resource object

drivers/irqchip/irq-imgpdc.c:327:20-23: WARNING: Suspicious code.
		resource_size is maybe missing with res_regs

Generated by: scripts/coccinelle/api/resource_size.cocci

Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: marc.zyngier@arm.com
Cc: jason@lakedaemon.net
Link: https://lkml.kernel.org/r/1511215361-8279-1-git-send-email-gomonovych@gmail.com
---
 drivers/irqchip/irq-imgpdc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-imgpdc.c b/drivers/irqchip/irq-imgpdc.c
index 1f59998..e80263e 100644
--- a/drivers/irqchip/irq-imgpdc.c
+++ b/drivers/irqchip/irq-imgpdc.c
@@ -325,7 +325,7 @@ static int pdc_intc_probe(struct platform_device *pdev)
 
 	/* Ioremap the registers */
 	priv->pdc_base = devm_ioremap(&pdev->dev, res_regs->start,
-				      res_regs->end - res_regs->start);
+				      resource_size(res_regs));
 	if (!priv->pdc_base)
 		return -EIO;
 

  reply	other threads:[~2017-11-23 19:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-20 22:02 [PATCH] irq-imgpdc: " Vasyl Gomonovych
2017-11-23 19:10 ` tip-bot for Vasyl Gomonovych [this message]
2017-11-23 19:12 ` [tip:irq/urgent] irqchip/imgpdc: " tip-bot for Vasyl Gomonovych

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-a994988d73db142fbe842ce08bbda62b12456577@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=gomonovych@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome