From: tip-bot for Li Zefan <lizf@cn.fujitsu.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
rostedt@goodmis.org, lizf@cn.fujitsu.com, tglx@linutronix.de
Subject: [tip:tracing/core] tracing/events: put TP_fast_assign into braces
Date: Thu, 4 Jun 2009 12:04:16 GMT [thread overview]
Message-ID: <tip-a9c1c3abe1160a5632e48c929b02b740556bf423@git.kernel.org> (raw)
In-Reply-To: <4A2384B1.90100@cn.fujitsu.com>
Commit-ID: a9c1c3abe1160a5632e48c929b02b740556bf423
Gitweb: http://git.kernel.org/tip/a9c1c3abe1160a5632e48c929b02b740556bf423
Author: Li Zefan <lizf@cn.fujitsu.com>
AuthorDate: Mon, 1 Jun 2009 15:35:13 +0800
Committer: Steven Rostedt <rostedt@goodmis.org>
CommitDate: Mon, 1 Jun 2009 23:24:53 -0400
tracing/events: put TP_fast_assign into braces
Currently TP_fast_assign has a limitation that we can't define local
variables in it.
Here's one use case when we introduce __dynamic_array():
TP_fast_assign(
type *p = __get_dynamic_array(item);
foo(p);
bar(p);
),
[ Impact: allow defining local variables in TP_fast_assign ]
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
LKML-Reference: <4A2384B1.90100@cn.fujitsu.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
include/trace/ftrace.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/trace/ftrace.h b/include/trace/ftrace.h
index 9276ec4..ee92682 100644
--- a/include/trace/ftrace.h
+++ b/include/trace/ftrace.h
@@ -471,7 +471,7 @@ static void ftrace_raw_event_##call(proto) \
return; \
entry = ring_buffer_event_data(event); \
\
- assign; \
+ { assign; } \
\
if (!filter_current_check_discard(event_call, entry, event)) \
trace_nowake_buffer_unlock_commit(event, irq_flags, pc); \
prev parent reply other threads:[~2009-06-04 12:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-01 7:35 [PATCH 1/2] " Li Zefan
2009-06-01 7:35 ` [PATCH 2/2] tracing/events: introduce __dynamic_array() Li Zefan
2009-06-01 8:30 ` Christoph Hellwig
2009-06-01 13:12 ` Steven Rostedt
2009-06-01 16:36 ` Frederic Weisbecker
2009-06-04 12:04 ` [tip:tracing/core] " tip-bot for Li Zefan
2009-06-01 8:29 ` [PATCH 1/2] tracing/events: put TP_fast_assign into braces Christoph Hellwig
2009-06-01 13:11 ` Steven Rostedt
2009-06-01 13:16 ` Frederic Weisbecker
2009-06-04 12:04 ` tip-bot for Li Zefan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-a9c1c3abe1160a5632e48c929b02b740556bf423@git.kernel.org \
--to=lizf@cn.fujitsu.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome