From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760939AbdDSIOR (ORCPT ); Wed, 19 Apr 2017 04:14:17 -0400 Received: from terminus.zytor.com ([65.50.211.136]:53373 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760821AbdDSIOO (ORCPT ); Wed, 19 Apr 2017 04:14:14 -0400 Date: Wed, 19 Apr 2017 01:08:37 -0700 From: tip-bot for Josh Poimboeuf Message-ID: Cc: jpoimboe@redhat.com, brgerst@gmail.com, luto@kernel.org, bp@alien8.de, peterz@infradead.org, mingo@kernel.org, dvlasenk@redhat.com, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, hpa@zytor.com Reply-To: mingo@kernel.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, hpa@zytor.com, dvlasenk@redhat.com, torvalds@linux-foundation.org, jpoimboe@redhat.com, brgerst@gmail.com, luto@kernel.org, peterz@infradead.org, bp@alien8.de In-Reply-To: <08cb36b004629f6bbcf44c267ae4a609242ebd0b.1492520933.git.jpoimboe@redhat.com> References: <08cb36b004629f6bbcf44c267ae4a609242ebd0b.1492520933.git.jpoimboe@redhat.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/asm] x86/unwind: Remove unused 'sp' parameter in unwind_dump() Git-Commit-ID: aa4f853461aab5f526a312bf418091a95626632b X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: aa4f853461aab5f526a312bf418091a95626632b Gitweb: http://git.kernel.org/tip/aa4f853461aab5f526a312bf418091a95626632b Author: Josh Poimboeuf AuthorDate: Tue, 18 Apr 2017 08:12:58 -0500 Committer: Ingo Molnar CommitDate: Wed, 19 Apr 2017 09:59:47 +0200 x86/unwind: Remove unused 'sp' parameter in unwind_dump() The 'sp' parameter to unwind_dump() is unused. Remove it. Signed-off-by: Josh Poimboeuf Cc: Andy Lutomirski Cc: Borislav Petkov Cc: Brian Gerst Cc: Denys Vlasenko Cc: H. Peter Anvin Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Link: http://lkml.kernel.org/r/08cb36b004629f6bbcf44c267ae4a609242ebd0b.1492520933.git.jpoimboe@redhat.com Signed-off-by: Ingo Molnar --- arch/x86/kernel/unwind_frame.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/x86/kernel/unwind_frame.c b/arch/x86/kernel/unwind_frame.c index 5d26374..bda82df 100644 --- a/arch/x86/kernel/unwind_frame.c +++ b/arch/x86/kernel/unwind_frame.c @@ -25,11 +25,11 @@ val; \ }) -static void unwind_dump(struct unwind_state *state, unsigned long *sp) +static void unwind_dump(struct unwind_state *state) { static bool dumped_before = false; bool prev_zero, zero = false; - unsigned long word; + unsigned long word, *sp; if (dumped_before) return; @@ -287,13 +287,13 @@ bad_address: "WARNING: kernel stack regs at %p in %s:%d has bad 'bp' value %p\n", state->regs, state->task->comm, state->task->pid, next_bp); - unwind_dump(state, (unsigned long *)state->regs); + unwind_dump(state); } else { printk_deferred_once(KERN_WARNING "WARNING: kernel stack frame pointer at %p in %s:%d has bad value %p\n", state->bp, state->task->comm, state->task->pid, next_bp); - unwind_dump(state, state->bp); + unwind_dump(state); } the_end: state->stack_info.type = STACK_TYPE_UNKNOWN;