From: tip-bot for Namhyung Kim <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: acme@redhat.com, linux-kernel@vger.kernel.org, hpa@zytor.com,
mingo@kernel.org, a.p.zijlstra@chello.nl, namhyung.kim@lge.com,
namhyung@kernel.org, jolsa@redhat.com, fweisbec@gmail.com,
rostedt@goodmis.org, tglx@linutronix.de
Subject: [tip:perf/core] tools lib traceevent: Unregister handler when function plugin is unloaded
Date: Sun, 19 Jan 2014 04:22:52 -0800 [thread overview]
Message-ID: <tip-ac668c7b7d87c1895faf196a337b5ddfd32a0e21@git.kernel.org> (raw)
In-Reply-To: <1389839478-5887-4-git-send-email-namhyung@kernel.org>
Commit-ID: ac668c7b7d87c1895faf196a337b5ddfd32a0e21
Gitweb: http://git.kernel.org/tip/ac668c7b7d87c1895faf196a337b5ddfd32a0e21
Author: Namhyung Kim <namhyung@kernel.org>
AuthorDate: Thu, 16 Jan 2014 11:31:09 +0900
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Thu, 16 Jan 2014 16:26:24 -0300
tools lib traceevent: Unregister handler when function plugin is unloaded
The function handler should be unregistered when the plugin is unloaded
otherwise it'll try to access invalid memory.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Reviewed-by: Jiri Olsa <jolsa@redhat.com>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung.kim@lge.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Steven Rostedt <rostedt@goodmis.org>
Link: http://lkml.kernel.org/r/1389839478-5887-4-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/lib/traceevent/plugin_function.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/lib/traceevent/plugin_function.c b/tools/lib/traceevent/plugin_function.c
index 3946148..80ba4ff 100644
--- a/tools/lib/traceevent/plugin_function.c
+++ b/tools/lib/traceevent/plugin_function.c
@@ -148,6 +148,9 @@ void PEVENT_PLUGIN_UNLOADER(struct pevent *pevent)
{
int i, x;
+ pevent_unregister_event_handler(pevent, -1, "ftrace", "function",
+ function_handler, NULL);
+
for (i = 0; i <= cpus; i++) {
for (x = 0; x < fstack[i].size && fstack[i].stack[x]; x++)
free(fstack[i].stack[x]);
next prev parent reply other threads:[~2014-01-19 12:23 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 2:31 [PATCHSET 00/12] tools lib traceevent: Plugin unload enhancement (v2) Namhyung Kim
2014-01-16 2:31 ` [PATCH 01/12] tools lib traceevent: Add pevent_unregister_event_handler() Namhyung Kim
2014-01-19 12:22 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-01-16 2:31 ` [PATCH 02/12] tools lib traceevent: Add pevent_unregister_print_function() Namhyung Kim
2014-01-19 12:22 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-01-16 2:31 ` [PATCH 03/12] tools lib traceevent: Unregister handler when function plugin unloaded Namhyung Kim
2014-01-19 12:22 ` tip-bot for Namhyung Kim [this message]
2014-01-16 2:31 ` [PATCH 04/12] tools lib traceevent: Unregister handler when hrtimer " Namhyung Kim
2014-01-19 12:23 ` [tip:perf/core] tools lib traceevent: Unregister handler when hrtimer plugin is unloaded tip-bot for Namhyung Kim
2014-01-16 2:31 ` [PATCH 05/12] tools lib traceevent: Unregister handler when kmem plugin unloaded Namhyung Kim
2014-01-19 12:23 ` [tip:perf/core] tools lib traceevent: Unregister handler when kmem plugin is unloaded tip-bot for Namhyung Kim
2014-01-16 2:31 ` [PATCH 06/12] tools lib traceevent: Unregister handler when kvm plugin unloaded Namhyung Kim
2014-01-19 12:23 ` [tip:perf/core] tools lib traceevent: Unregister handler when kvm plugin is unloaded tip-bot for Namhyung Kim
2014-01-16 2:31 ` [PATCH 07/12] tools lib traceevent: Unregister handler when sched_switch plugin unloaded Namhyung Kim
2014-01-19 12:23 ` [tip:perf/core] tools lib traceevent: Unregister handler when sched_switch plugin is unloaded tip-bot for Namhyung Kim
2014-01-16 2:31 ` [PATCH 08/12] tools lib traceevent: Unregister handler when mac80211 plugin unloaded Namhyung Kim
2014-01-19 12:23 ` [tip:perf/core] tools lib traceevent: Unregister handler when mac80211 plugin is unloaded tip-bot for Namhyung Kim
2014-01-16 2:31 ` [PATCH 09/12] tools lib traceevent: Unregister handler when cfg80211 plugin unloaded Namhyung Kim
2014-01-16 3:23 ` Steven Rostedt
2014-01-19 12:23 ` [tip:perf/core] tools lib traceevent: Unregister handler when cfg80211 plugin is unloaded tip-bot for Namhyung Kim
2014-01-16 2:31 ` [PATCH 10/12] tools lib traceevent: Unregister handler when jbd2 plugin unloaded Namhyung Kim
2014-01-19 12:24 ` [tip:perf/core] tools lib traceevent: Unregister handler when jbd2 plugin is is unloaded tip-bot for Namhyung Kim
2014-01-16 2:31 ` [PATCH 11/12] tools lib traceevent: Unregister handler when scsi plugin unloaded Namhyung Kim
2014-01-19 12:24 ` [tip:perf/core] tools lib traceevent: Unregister handler when scsi plugin is unloaded tip-bot for Namhyung Kim
2014-01-16 2:31 ` [PATCH 12/12] tools lib traceevent: Unregister handler when xen plugin unloaded Namhyung Kim
2014-01-19 12:24 ` [tip:perf/core] tools lib traceevent: Unregister handler when xen plugin is unloaded tip-bot for Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-ac668c7b7d87c1895faf196a337b5ddfd32a0e21@git.kernel.org \
--to=tipbot@zytor.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome