From: tip-bot for Alexander Yarygin <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
borntraeger@de.ibm.com, jolsa@redhat.com,
yarygin@linux.vnet.ibm.com, dsahern@gmail.com,
tglx@linutronix.de
Subject: [tip:perf/urgent] perf kvm: Fix 'Min time' counting in report command
Date: Sun, 20 Apr 2014 01:03:33 -0700 [thread overview]
Message-ID: <tip-acb61fc8ed73eb477a9044272d7a1b1f5a572f91@git.kernel.org> (raw)
In-Reply-To: <1397053319-2130-3-git-send-email-borntraeger@de.ibm.com>
Commit-ID: acb61fc8ed73eb477a9044272d7a1b1f5a572f91
Gitweb: http://git.kernel.org/tip/acb61fc8ed73eb477a9044272d7a1b1f5a572f91
Author: Alexander Yarygin <yarygin@linux.vnet.ibm.com>
AuthorDate: Wed, 9 Apr 2014 16:21:59 +0200
Committer: Jiri Olsa <jolsa@redhat.com>
CommitDate: Sun, 20 Apr 2014 00:14:08 +0200
perf kvm: Fix 'Min time' counting in report command
Every event in the perf-kvm has a 'stats' structure, which contains
max/min/average/etc times of handling this event.
The problem is that the 'perf-kvm stat report' command always shows
that 'min time' is 0us for every event. Example:
# perf kvm stat report
Analyze events for all VCPUs:
VM-EXIT Samples Samples% Time% Min Time Max Time Avg time
[..]
0xB2 MSCH 12 0.07% 0.00% 0us 8us 7.31us ( +- 2.11% )
0xB2 CHSC 12 0.07% 0.00% 0us 18us 9.39us ( +- 9.49% )
0xB2 STPX 8 0.05% 0.00% 0us 2us 1.88us ( +- 7.18% )
0xB2 STSI 7 0.04% 0.00% 0us 44us 16.49us ( +- 38.20% )
[..]
This happens because the 'stats' structure is not initialized and
stats->min equals to 0. Lets initialize the structure for every
event after its allocation using init_stats() function. This initializes
stats->min to -1 and makes 'Min time' statistics counting work:
# perf kvm stat report
Analyze events for all VCPUs:
VM-EXIT Samples Samples% Time% Min Time Max Time Avg time
[..]
0xB2 MSCH 12 0.07% 0.00% 6us 8us 7.31us ( +- 2.11% )
0xB2 CHSC 12 0.07% 0.00% 7us 18us 9.39us ( +- 9.49% )
0xB2 STPX 8 0.05% 0.00% 1us 2us 1.88us ( +- 7.18% )
0xB2 STSI 7 0.04% 0.00% 1us 44us 16.49us ( +- 38.20% )
[..]
Signed-off-by: Alexander Yarygin <yarygin@linux.vnet.ibm.com>
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Reviewed-by: David Ahern <dsahern@gmail.com>
Link: http://lkml.kernel.org/r/1397053319-2130-3-git-send-email-borntraeger@de.ibm.com
[ Fixing the perf examples changelog output ]
Signed-off-by: Jiri Olsa <jolsa@redhat.com>
---
tools/perf/builtin-kvm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/perf/builtin-kvm.c b/tools/perf/builtin-kvm.c
index 21c164b..0f1e5a2 100644
--- a/tools/perf/builtin-kvm.c
+++ b/tools/perf/builtin-kvm.c
@@ -404,6 +404,7 @@ static struct kvm_event *kvm_alloc_init_event(struct event_key *key)
}
event->key = *key;
+ init_stats(&event->total.stats);
return event;
}
next prev parent reply other threads:[~2014-04-20 8:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 14:21 [PULL 0/2] small perf fixes Christian Borntraeger
2014-04-09 14:21 ` [PULL 1/2] perf/tool: Fix usage of trace events with '-' in trace system name Christian Borntraeger
2014-04-16 13:00 ` Jiri Olsa
2014-04-16 13:28 ` Christian Borntraeger
2014-04-16 13:31 ` Christian Borntraeger
2014-04-16 13:39 ` Jiri Olsa
2014-04-09 14:21 ` [PULL 2/2] perf-kvm: fix of 'Min time' counting in report command Christian Borntraeger
2014-04-09 15:10 ` David Ahern
2014-04-20 8:03 ` tip-bot for Alexander Yarygin [this message]
2014-04-15 13:05 ` [PULL 0/2] small perf fixes Christian Borntraeger
2014-04-15 13:17 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-acb61fc8ed73eb477a9044272d7a1b1f5a572f91@git.kernel.org \
--to=tipbot@zytor.com \
--cc=borntraeger@de.ibm.com \
--cc=dsahern@gmail.com \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=yarygin@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome