From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932309AbdELIhZ (ORCPT ); Fri, 12 May 2017 04:37:25 -0400 Received: from terminus.zytor.com ([65.50.211.136]:49413 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932189AbdELIhU (ORCPT ); Fri, 12 May 2017 04:37:20 -0400 Date: Fri, 12 May 2017 01:35:07 -0700 From: tip-bot for Hanjun Guo Message-ID: Cc: weiyongjun1@huawei.com, wangkefeng.wang@huawei.com, linux-kernel@vger.kernel.org, majun258@huawei.com, hpa@zytor.com, hanjun.guo@linaro.org, mingo@kernel.org, marc.zyngier@arm.com, tglx@linutronix.de Reply-To: hanjun.guo@linaro.org, mingo@kernel.org, marc.zyngier@arm.com, tglx@linutronix.de, wangkefeng.wang@huawei.com, weiyongjun1@huawei.com, hpa@zytor.com, majun258@huawei.com, linux-kernel@vger.kernel.org In-Reply-To: <1494561328-39514-3-git-send-email-guohanjun@huawei.com> References: <1494561328-39514-3-git-send-email-guohanjun@huawei.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:irq/urgent] irqchip/mbigen: Fix potential NULL dereferencing Git-Commit-ID: ad7cc3c0c57d77b442db323056354d0e49833569 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: ad7cc3c0c57d77b442db323056354d0e49833569 Gitweb: http://git.kernel.org/tip/ad7cc3c0c57d77b442db323056354d0e49833569 Author: Hanjun Guo AuthorDate: Fri, 12 May 2017 11:55:27 +0800 Committer: Thomas Gleixner CommitDate: Fri, 12 May 2017 10:25:37 +0200 irqchip/mbigen: Fix potential NULL dereferencing platform_get_resource() may return NULL, add proper check to avoid potential NULL dereferencing. Signed-off-by: Hanjun Guo Acked-by: Marc Zyngier Cc: Kefeng Wang Cc: linuxarm@huawei.com Cc: Wei Yongjun Cc: MaJun Link: http://lkml.kernel.org/r/1494561328-39514-3-git-send-email-guohanjun@huawei.com Signed-off-by: Thomas Gleixner --- drivers/irqchip/irq-mbigen.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/irqchip/irq-mbigen.c b/drivers/irqchip/irq-mbigen.c index 0f5e66e..2fa1e45 100644 --- a/drivers/irqchip/irq-mbigen.c +++ b/drivers/irqchip/irq-mbigen.c @@ -337,6 +337,9 @@ static int mbigen_device_probe(struct platform_device *pdev) mgn_chip->pdev = pdev; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!res) + return -EINVAL; + mgn_chip->base = devm_ioremap(&pdev->dev, res->start, resource_size(res)); if (!mgn_chip->base) {