From: tip-bot for Peter Foley <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: hpa@zytor.com, torvalds@linux-foundation.org, mingo@kernel.org,
peterz@infradead.org, tglx@linutronix.de, pefoley2@pefoley.com,
linux-kernel@vger.kernel.org
Subject: [tip:x86/urgent] x86/build: Annotate die() with noreturn to fix build warning on clang
Date: Sun, 27 Nov 2016 23:20:25 -0800 [thread overview]
Message-ID: <tip-adee8705d2517f0e163ffc45e8d7f9e97a58f1f6@git.kernel.org> (raw)
In-Reply-To: <20161126222229.673-1-pefoley2@pefoley.com>
Commit-ID: adee8705d2517f0e163ffc45e8d7f9e97a58f1f6
Gitweb: http://git.kernel.org/tip/adee8705d2517f0e163ffc45e8d7f9e97a58f1f6
Author: Peter Foley <pefoley2@pefoley.com>
AuthorDate: Sat, 26 Nov 2016 17:22:29 -0500
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 28 Nov 2016 07:47:22 +0100
x86/build: Annotate die() with noreturn to fix build warning on clang
Fixes below warning with clang:
In file included from ../arch/x86/tools/relocs_64.c:17:
../arch/x86/tools/relocs.c:977:6: warning: variable 'do_reloc' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
Signed-off-by: Peter Foley <pefoley2@pefoley.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20161126222229.673-1-pefoley2@pefoley.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/tools/relocs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/tools/relocs.h b/arch/x86/tools/relocs.h
index f595906..1d23bf9 100644
--- a/arch/x86/tools/relocs.h
+++ b/arch/x86/tools/relocs.h
@@ -16,7 +16,7 @@
#include <regex.h>
#include <tools/le_byteshift.h>
-void die(char *fmt, ...);
+void die(char *fmt, ...) __attribute__((noreturn));
#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))
prev parent reply other threads:[~2016-11-28 7:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-26 22:22 [PATCH] Annotate die() with noreturn Peter Foley
2016-11-28 7:20 ` tip-bot for Peter Foley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-adee8705d2517f0e163ffc45e8d7f9e97a58f1f6@git.kernel.org \
--to=tipbot@zytor.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pefoley2@pefoley.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome