From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751785AbcFNL0H (ORCPT ); Tue, 14 Jun 2016 07:26:07 -0400 Received: from terminus.zytor.com ([198.137.202.10]:33874 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751612AbcFNL0F (ORCPT ); Tue, 14 Jun 2016 07:26:05 -0400 Date: Tue, 14 Jun 2016 04:24:57 -0700 From: tip-bot for Tony Luck Message-ID: Cc: bp@suse.de, luto@amacapital.net, torvalds@linux-foundation.org, dvlasenk@redhat.com, tglx@linutronix.de, hpa@zytor.com, linux-kernel@vger.kernel.org, peterz@infradead.org, bp@alien8.de, brgerst@gmail.com, linux-edac@vger.kernel.org, tony.luck@intel.com, mingo@kernel.org, arozansk@redhat.com, mchehab@osg.samsung.com Reply-To: bp@suse.de, luto@amacapital.net, dvlasenk@redhat.com, tglx@linutronix.de, torvalds@linux-foundation.org, bp@alien8.de, peterz@infradead.org, linux-kernel@vger.kernel.org, hpa@zytor.com, brgerst@gmail.com, mingo@kernel.org, linux-edac@vger.kernel.org, tony.luck@intel.com, mchehab@osg.samsung.com, arozansk@redhat.com In-Reply-To: References: To: linux-tip-commits@vger.kernel.org Subject: [tip:ras/core] x86/mce: Do not use bank 1 for APEI generated error logs Git-Commit-ID: b2de43605410d1970dc9e0f349e399f1d561be13 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: b2de43605410d1970dc9e0f349e399f1d561be13 Gitweb: http://git.kernel.org/tip/b2de43605410d1970dc9e0f349e399f1d561be13 Author: Tony Luck AuthorDate: Fri, 27 May 2016 14:11:06 -0700 Committer: Ingo Molnar CommitDate: Tue, 14 Jun 2016 10:51:14 +0200 x86/mce: Do not use bank 1 for APEI generated error logs BIOS can report a memory error to Linux using ACPI/APEI mechanism. When it does this, we create a fictitious machine check error record and feed it into the standard mce_log() function. The error record needs a machine check bank number, and for some reason we chose "1" for this. But "1" is a valid bank number, and this causes confusion and heartburn among h/w folks who are concerned that a memory error signature was somehow logged in bank 1. Change to use "-1" (field is a "u8" so will typically print as 255). This should make it clearer that this error did not originate in a machine check bank. Signed-off-by: Tony Luck Signed-off-by: Borislav Petkov Cc: Andy Lutomirski Cc: Aristeu Rozanski Cc: Borislav Petkov Cc: Brian Gerst Cc: Denys Vlasenko Cc: H. Peter Anvin Cc: Linus Torvalds Cc: Mauro Carvalho Chehab Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: linux-edac Link: http://lkml.kernel.org/r/b7fffb2b326bc1dd150ffceb9919a803f9496e0e.1464805958.git.tony.luck@intel.com Signed-off-by: Ingo Molnar --- arch/x86/kernel/cpu/mcheck/mce-apei.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/cpu/mcheck/mce-apei.c b/arch/x86/kernel/cpu/mcheck/mce-apei.c index 34c89a3..83f1a98 100644 --- a/arch/x86/kernel/cpu/mcheck/mce-apei.c +++ b/arch/x86/kernel/cpu/mcheck/mce-apei.c @@ -46,7 +46,7 @@ void apei_mce_report_mem_error(int severity, struct cper_sec_mem_err *mem_err) return; mce_setup(&m); - m.bank = 1; + m.bank = -1; /* Fake a memory read error with unknown channel */ m.status = MCI_STATUS_VAL | MCI_STATUS_EN | MCI_STATUS_ADDRV | 0x9f;