From: tip-bot for Alex Shi <alex.shi@intel.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
a.p.zijlstra@chello.nl, ncrao@google.com, efault@gmx.de,
alex.shi@intel.com, tglx@linutronix.de, mingo@elte.hu
Subject: [tip:sched/urgent] sched: Fix volanomark performance regression
Date: Thu, 18 Nov 2010 14:08:40 GMT [thread overview]
Message-ID: <tip-b5482cfa1c95a188b3054fa33274806add91bbe5@git.kernel.org> (raw)
In-Reply-To: <1289928732.5169.211.camel@maggy.simson.net>
Commit-ID: b5482cfa1c95a188b3054fa33274806add91bbe5
Gitweb: http://git.kernel.org/tip/b5482cfa1c95a188b3054fa33274806add91bbe5
Author: Alex Shi <alex.shi@intel.com>
AuthorDate: Tue, 16 Nov 2010 17:34:02 +0800
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Thu, 18 Nov 2010 13:11:43 +0100
sched: Fix volanomark performance regression
Commit fab4762 triggers excessive idle balancing, causing a ~30% loss in
volanomark throughput. Remove idle balancing throttle reset.
Originally-by: Alex Shi <alex.shi@intel.com>
Signed-off-by: Mike Galbraith <efault@gmx.de>
Acked-by: Nikhil Rao <ncrao@google.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <1289928732.5169.211.camel@maggy.simson.net>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
kernel/sched_fair.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c
index 52ab113..ba0556d 100644
--- a/kernel/sched_fair.c
+++ b/kernel/sched_fair.c
@@ -1758,10 +1758,6 @@ static void pull_task(struct rq *src_rq, struct task_struct *p,
set_task_cpu(p, this_cpu);
activate_task(this_rq, p, 0);
check_preempt_curr(this_rq, p, 0);
-
- /* re-arm NEWIDLE balancing when moving tasks */
- src_rq->avg_idle = this_rq->avg_idle = 2*sysctl_sched_migration_cost;
- this_rq->idle_stamp = 0;
}
/*
next prev parent reply other threads:[~2010-11-18 14:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-16 9:34 [performance bug] volanomark regression on 37-rc1 Alex,Shi
2010-11-16 14:38 ` Rakib Mullick
2010-11-16 15:26 ` Mike Galbraith
2010-11-16 16:31 ` Nikhil Rao
2010-11-16 17:32 ` Mike Galbraith
2010-11-16 19:27 ` Nikhil Rao
2010-11-16 19:37 ` Peter Zijlstra
2010-11-17 1:17 ` Alex,Shi
[not found] ` <1290022924-3548-1-git-send-email-ncrao@google.com>
2010-11-17 19:45 ` Nikhil Rao
2010-11-18 14:08 ` [tip:sched/urgent] sched: Fix idle balancing tip-bot for Nikhil Rao
2010-11-18 14:08 ` tip-bot for Alex Shi [this message]
2010-11-17 0:23 ` [performance bug] volanomark regression on 37-rc1 Alex,Shi
2010-11-16 16:21 ` Nikhil Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-b5482cfa1c95a188b3054fa33274806add91bbe5@git.kernel.org \
--to=alex.shi@intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=efault@gmx.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=ncrao@google.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome