From: tip-bot for Valentin Schneider <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: valentin.schneider@arm.com, tglx@linutronix.de,
linux-kernel@vger.kernel.org, paulmck@linux.vnet.ibm.com,
torvalds@linux-foundation.org, hpa@zytor.com,
peterz@infradead.org, will.deacon@arm.com,
akpm@linux-foundation.org, mingo@kernel.org
Subject: [tip:locking/core] Revert "sched/core: Take the hotplug lock in sched_init_smp()"
Date: Mon, 21 Jan 2019 03:30:45 -0800 [thread overview]
Message-ID: <tip-b5a4e2bb0f4c86bfeb38df3e1d5b2f1272f0e673@git.kernel.org> (raw)
In-Reply-To: <1545243796-23224-3-git-send-email-valentin.schneider@arm.com>
Commit-ID: b5a4e2bb0f4c86bfeb38df3e1d5b2f1272f0e673
Gitweb: https://git.kernel.org/tip/b5a4e2bb0f4c86bfeb38df3e1d5b2f1272f0e673
Author: Valentin Schneider <valentin.schneider@arm.com>
AuthorDate: Wed, 19 Dec 2018 18:23:16 +0000
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 21 Jan 2019 11:18:54 +0100
Revert "sched/core: Take the hotplug lock in sched_init_smp()"
This reverts commit 40fa3780bac2b654edf23f6b13f4e2dd550aea10.
Now that we have a system-wide muting of hotplug lockdep during init,
this is no longer needed.
Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Will Deacon <will.deacon@arm.com>
Cc: cai@gmx.us
Cc: daniel.lezcano@linaro.org
Cc: dietmar.eggemann@arm.com
Cc: linux-arm-kernel@lists.infradead.org
Cc: longman@redhat.com
Cc: marc.zyngier@arm.com
Cc: mark.rutland@arm.com
Link: https://lkml.kernel.org/r/1545243796-23224-3-git-send-email-valentin.schneider@arm.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
kernel/sched/core.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index b05eef7d7a1f..3c8b4dba3d2d 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -5867,14 +5867,11 @@ void __init sched_init_smp(void)
/*
* There's no userspace yet to cause hotplug operations; hence all the
* CPU masks are stable and all blatant races in the below code cannot
- * happen. The hotplug lock is nevertheless taken to satisfy lockdep,
- * but there won't be any contention on it.
+ * happen.
*/
- cpus_read_lock();
mutex_lock(&sched_domains_mutex);
sched_init_domains(cpu_active_mask);
mutex_unlock(&sched_domains_mutex);
- cpus_read_unlock();
/* Move init over to a non-isolated CPU */
if (set_cpus_allowed_ptr(current, housekeeping_cpumask(HK_FLAG_DOMAIN)) < 0)
next prev parent reply other threads:[~2019-01-21 11:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-19 18:23 [PATCH 0/2] System-wide mute of hotplug lockdep during init Valentin Schneider
2018-12-19 18:23 ` [PATCH 1/2] cpu/hotplug: Mute " Valentin Schneider
2018-12-19 18:31 ` Marc Zyngier
2019-01-21 11:30 ` [tip:locking/core] " tip-bot for Valentin Schneider
2018-12-19 18:23 ` [PATCH 2/2] Revert "sched/core: Take the hotplug lock in sched_init_smp()" Valentin Schneider
2019-01-21 11:30 ` tip-bot for Valentin Schneider [this message]
2019-01-11 9:53 ` [PATCH 0/2] System-wide mute of hotplug lockdep during init Valentin Schneider
2019-01-11 13:01 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-b5a4e2bb0f4c86bfeb38df3e1d5b2f1272f0e673@git.kernel.org \
--to=tipbot@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=valentin.schneider@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome