From: tip-bot for anish kumar <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
anish198519851985@gmail.com, tglx@linutronix.de,
dzickus@redhat.com
Subject: [tip:perf/core] watchdog: Add comments to explain the watchdog_disabled variable
Date: Mon, 18 Mar 2013 04:00:46 -0700 [thread overview]
Message-ID: <tip-b66a2356d7108a15b8b5c9b8e6213e05ead22cd6@git.kernel.org> (raw)
In-Reply-To: <1363113848-18344-1-git-send-email-dzickus@redhat.com>
Commit-ID: b66a2356d7108a15b8b5c9b8e6213e05ead22cd6
Gitweb: http://git.kernel.org/tip/b66a2356d7108a15b8b5c9b8e6213e05ead22cd6
Author: anish kumar <anish198519851985@gmail.com>
AuthorDate: Tue, 12 Mar 2013 14:44:08 -0400
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 14 Mar 2013 08:24:05 +0100
watchdog: Add comments to explain the watchdog_disabled variable
The watchdog_disabled flag is a bit cryptic. However it's
usefulness is multifold. Uses are:
1. Check if smpboot_register_percpu_thread function passed.
2. Makes sure that user enables and disables the watchdog in
sequence i.e. enable watchdog->disable watchdog->enable watchdog
Unlike enable watchdog->enable watchdog which is wrong.
Signed-off-by: anish kumar <anish198519851985@gmail.com>
[small text cleanups]
Signed-off-by: Don Zickus <dzickus@redhat.com>
Cc: chuansheng.liu@intel.com
Cc: paulmck@linux.vnet.ibm.com
Link: http://lkml.kernel.org/r/1363113848-18344-1-git-send-email-dzickus@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
kernel/watchdog.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/kernel/watchdog.c b/kernel/watchdog.c
index 4a94467..05039e3 100644
--- a/kernel/watchdog.c
+++ b/kernel/watchdog.c
@@ -517,6 +517,11 @@ int proc_dowatchdog(struct ctl_table *table, int write,
return ret;
set_sample_period();
+ /*
+ * Watchdog threads shouldn't be enabled if they are
+ * disabled. The 'watchdog_disabled' variable check in
+ * watchdog_*_all_cpus() function takes care of this.
+ */
if (watchdog_enabled && watchdog_thresh)
watchdog_enable_all_cpus();
else
prev parent reply other threads:[~2013-03-18 11:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 18:44 [PATCH] Add comments to explain " Don Zickus
2013-03-18 11:00 ` tip-bot for anish kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-b66a2356d7108a15b8b5c9b8e6213e05ead22cd6@git.kernel.org \
--to=tipbot@zytor.com \
--cc=anish198519851985@gmail.com \
--cc=dzickus@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome