From: tip-bot for Chuansheng Liu <chuansheng.liu@intel.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
peterz@infradead.org, tglx@linutronix.de,
chuansheng.liu@intel.com
Subject: [tip:timers/core] tick: Correct the comments for tick_sched_timer( )
Date: Thu, 1 Nov 2012 14:38:17 -0700 [thread overview]
Message-ID: <tip-b8f61116c1ce342804a0897b0a80eb4df5f19453@git.kernel.org> (raw)
In-Reply-To: <1351098455.15558.1421.camel@cliu38-desktop-build>
Commit-ID: b8f61116c1ce342804a0897b0a80eb4df5f19453
Gitweb: http://git.kernel.org/tip/b8f61116c1ce342804a0897b0a80eb4df5f19453
Author: Chuansheng Liu <chuansheng.liu@intel.com>
AuthorDate: Thu, 25 Oct 2012 01:07:35 +0800
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Thu, 1 Nov 2012 12:13:59 +0100
tick: Correct the comments for tick_sched_timer()
In the comments of function tick_sched_timer(), the sentence
"timer->base->cpu_base->lock held" is not right.
In function __run_hrtimer(), before call timer->function(),
the cpu_base->lock has been unlocked.
Signed-off-by: liu chuansheng <chuansheng.liu@intel.com>
Cc: fei.li@intel.com
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1351098455.15558.1421.camel@cliu38-desktop-build
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
kernel/time/tick-sched.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
index 766d4c4..77729cc 100644
--- a/kernel/time/tick-sched.c
+++ b/kernel/time/tick-sched.c
@@ -809,7 +809,7 @@ void tick_check_idle(int cpu)
#ifdef CONFIG_HIGH_RES_TIMERS
/*
* We rearm the timer until we get disabled by the idle code.
- * Called with interrupts disabled and timer->base->cpu_base->lock held.
+ * Called with interrupts disabled.
*/
static enum hrtimer_restart tick_sched_timer(struct hrtimer *timer)
{
prev parent reply other threads:[~2012-11-01 21:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-24 17:07 sched: correct the comments for tick_sched_timer() Chuansheng Liu
2012-10-24 9:41 ` [tip:timers/urgent] timers, sched: Correct " tip-bot for Chuansheng Liu
2012-11-01 21:38 ` tip-bot for Chuansheng Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-b8f61116c1ce342804a0897b0a80eb4df5f19453@git.kernel.org \
--to=chuansheng.liu@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome