From: tip-bot for Abhijeet Dharmapurikar <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
adharmap@codeaurora.org, tglx@linutronix.de,
sboyd@codeaurora.org
Subject: [tip:irq/urgent] irqchip: gic: fix irq_trigger return
Date: Tue, 26 Mar 2013 13:08:44 -0700 [thread overview]
Message-ID: <tip-bad9a43a20372a3b41e15e8aa03b918c76f360f0@git.kernel.org> (raw)
In-Reply-To: <1363734349-32635-1-git-send-email-sboyd@codeaurora.org>
Commit-ID: bad9a43a20372a3b41e15e8aa03b918c76f360f0
Gitweb: http://git.kernel.org/tip/bad9a43a20372a3b41e15e8aa03b918c76f360f0
Author: Abhijeet Dharmapurikar <adharmap@codeaurora.org>
AuthorDate: Tue, 19 Mar 2013 16:05:49 -0700
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Tue, 26 Mar 2013 20:52:25 +0100
irqchip: gic: fix irq_trigger return
The genirq layer expects a 0 in case that the retrigger function is
not able to resend the irq in hardware, but the code is returning
-ENXIO. Fix it.
[ tglx: Reworked comment and changelog ]
Signed-off-by: Abhijeet Dharmapurikar <adharmap@codeaurora.org>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Cc: linux-arm-kernel@lists.infradead.org
Link: http://lkml.kernel.org/r/1363734349-32635-1-git-send-email-sboyd@codeaurora.org
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
drivers/irqchip/irq-gic.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c
index a32e0d5..fc6aebf 100644
--- a/drivers/irqchip/irq-gic.c
+++ b/drivers/irqchip/irq-gic.c
@@ -236,7 +236,8 @@ static int gic_retrigger(struct irq_data *d)
if (gic_arch_extn.irq_retrigger)
return gic_arch_extn.irq_retrigger(d);
- return -ENXIO;
+ /* the genirq layer expects 0 if we can't retrigger in hardware */
+ return 0;
}
#ifdef CONFIG_SMP
prev parent reply other threads:[~2013-03-26 20:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 23:05 [PATCH] " Stephen Boyd
2013-03-26 17:33 ` Stephen Boyd
2013-03-26 20:08 ` tip-bot for Abhijeet Dharmapurikar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-bad9a43a20372a3b41e15e8aa03b918c76f360f0@git.kernel.org \
--to=tipbot@zytor.com \
--cc=adharmap@codeaurora.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome