From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752395AbbCVKK2 (ORCPT ); Sun, 22 Mar 2015 06:10:28 -0400 Received: from terminus.zytor.com ([198.137.202.10]:57080 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751799AbbCVKKZ (ORCPT ); Sun, 22 Mar 2015 06:10:25 -0400 Date: Sun, 22 Mar 2015 03:10:05 -0700 From: tip-bot for Yunlong Song Message-ID: Cc: tglx@linutronix.de, paulus@samba.org, linux-kernel@vger.kernel.org, mingo@kernel.org, hpa@zytor.com, yunlong.song@huawei.com, acme@redhat.com, a.p.zijlstra@chello.nl, wangnan0@huawei.com Reply-To: a.p.zijlstra@chello.nl, acme@redhat.com, wangnan0@huawei.com, yunlong.song@huawei.com, linux-kernel@vger.kernel.org, mingo@kernel.org, hpa@zytor.com, tglx@linutronix.de, paulus@samba.org In-Reply-To: <1426685758-25488-5-git-send-email-yunlong.song@huawei.com> References: <1426685758-25488-5-git-send-email-yunlong.song@huawei.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf tools: Fix the bash completion for listing events of perf subcommand record|stat|top -e Git-Commit-ID: bc81fad125dba7da33dbeac4c10d9c84614eb3ab X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: bc81fad125dba7da33dbeac4c10d9c84614eb3ab Gitweb: http://git.kernel.org/tip/bc81fad125dba7da33dbeac4c10d9c84614eb3ab Author: Yunlong Song AuthorDate: Wed, 18 Mar 2015 21:35:49 +0800 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 19 Mar 2015 13:49:37 -0300 perf tools: Fix the bash completion for listing events of perf subcommand record|stat|top -e The bash completion does not support listing events for 'perf kvm|kmem| mem|lock|sched record|stat|top -e ', where 'kvm|kmem|mem|lock|sched' are all subcommands of perf. Example: Before this patch: $ perf kvm record -e $ As shown above, the events of record does not come out. After this patch: $ perf kvm record -e alignment-faults cpu/instructions/ L1-dcache-prefetch-misses node-prefetches uncore_rbox_0/qpi0_idle_filt/ branch-instructions cpu/mem-loads/ L1-dcache-store-misses node-prefetch-misses uncore_rbox_0/qpi1_date_response/ branch-load-misses cpu-migrations L1-dcache-stores node-store-misses uncore_rbox_0/qpi1_filt_send/ branch-loads dTLB-load-misses L1-icache-load-misses node-stores uncore_rbox_0/qpi1_idle_filt/ ... As shown above, the events of record can come out now. Signed-off-by: Yunlong Song Tested-by: Arnaldo Carvalho de Melo Cc: Paul Mackerras Cc: Peter Zijlstra Cc: Wang Nan Link: http://lkml.kernel.org/r/1426685758-25488-5-git-send-email-yunlong.song@huawei.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/perf-completion.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/perf-completion.sh b/tools/perf/perf-completion.sh index 01ce841..4b58ac2 100644 --- a/tools/perf/perf-completion.sh +++ b/tools/perf/perf-completion.sh @@ -138,7 +138,7 @@ __perf_main () fi __perfcomp "$cmds" "$cur" # List possible events for -e option - elif [[ $prev == "-e" && "${words[1]}" == @(record|stat|top) ]]; then + elif [[ $prev == "-e" && $prev_skip_opts == @(record|stat|top) ]]; then evts=$($cmd list --raw-dump) __perfcomp_colon "$evts" "$cur" else