mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tip-bot for Fenghua Yu <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: ravi.v.shankar@intel.com, hpa@zytor.com, mingo@kernel.org,
	bp@alien8.de, luto@kernel.org, fenghua.yu@intel.com,
	ashok.raj@intel.com, tony.luck@intel.com, peterz@infradead.org,
	linux-kernel@vger.kernel.org, tglx@linutronix.de
Subject: [tip:x86/cpu] x86/umwait: Add sysfs interface to control umwait maximum time
Date: Sun, 23 Jun 2019 17:03:17 -0700	[thread overview]
Message-ID: <tip-bd9a0c97e53c3d7a56b2751179903ddc5da42683@git.kernel.org> (raw)
In-Reply-To: <1560994438-235698-5-git-send-email-fenghua.yu@intel.com>

Commit-ID:  bd9a0c97e53c3d7a56b2751179903ddc5da42683
Gitweb:     https://git.kernel.org/tip/bd9a0c97e53c3d7a56b2751179903ddc5da42683
Author:     Fenghua Yu <fenghua.yu@intel.com>
AuthorDate: Wed, 19 Jun 2019 18:33:57 -0700
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Mon, 24 Jun 2019 01:44:20 +0200

x86/umwait: Add sysfs interface to control umwait maximum time

IA32_UMWAIT_CONTROL[31:2] determines the maximum time in TSC-quanta
that processor can stay in C0.1 or C0.2. A zero value means no maximum
time.

Each instruction sets its own deadline in the instruction's implicit
input EDX:EAX value. The instruction wakes up if the time-stamp counter
reaches or exceeds the specified deadline, or the umwait maximum time
expires, or a store happens in the monitored address range in umwait.

The administrator can write an unsigned 32-bit number to
/sys/devices/system/cpu/umwait_control/max_time to change the default
value. Note that a value of zero means there is no limit. The lower two
bits of the value must be zero.

[ tglx: Simplify the write function. Massage changelog ]

Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Ashok Raj <ashok.raj@intel.com>
Reviewed-by: Tony Luck <tony.luck@intel.com>
Cc: "Borislav Petkov" <bp@alien8.de>
Cc: "H Peter Anvin" <hpa@zytor.com>
Cc: "Andy Lutomirski" <luto@kernel.org>
Cc: "Peter Zijlstra" <peterz@infradead.org>
Cc: "Ravi V Shankar" <ravi.v.shankar@intel.com>
Link: https://lkml.kernel.org/r/1560994438-235698-5-git-send-email-fenghua.yu@intel.com

---
 arch/x86/kernel/cpu/umwait.c | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/arch/x86/kernel/cpu/umwait.c b/arch/x86/kernel/cpu/umwait.c
index 56149d630e35..6a204e7336c1 100644
--- a/arch/x86/kernel/cpu/umwait.c
+++ b/arch/x86/kernel/cpu/umwait.c
@@ -131,8 +131,44 @@ static ssize_t enable_c02_store(struct device *dev,
 }
 static DEVICE_ATTR_RW(enable_c02);
 
+static ssize_t
+max_time_show(struct device *kobj, struct device_attribute *attr, char *buf)
+{
+	u32 ctrl = READ_ONCE(umwait_control_cached);
+
+	return sprintf(buf, "%u\n", umwait_ctrl_max_time(ctrl));
+}
+
+static ssize_t max_time_store(struct device *kobj,
+			      struct device_attribute *attr,
+			      const char *buf, size_t count)
+{
+	u32 max_time, ctrl;
+	int ret;
+
+	ret = kstrtou32(buf, 0, &max_time);
+	if (ret)
+		return ret;
+
+	/* bits[1:0] must be zero */
+	if (max_time & ~MSR_IA32_UMWAIT_CONTROL_TIME_MASK)
+		return -EINVAL;
+
+	mutex_lock(&umwait_lock);
+
+	ctrl = READ_ONCE(umwait_control_cached);
+	if (max_time != umwait_ctrl_max_time(ctrl))
+		umwait_update_control(max_time, umwait_ctrl_c02_enabled(ctrl));
+
+	mutex_unlock(&umwait_lock);
+
+	return count;
+}
+static DEVICE_ATTR_RW(max_time);
+
 static struct attribute *umwait_attrs[] = {
 	&dev_attr_enable_c02.attr,
+	&dev_attr_max_time.attr,
 	NULL
 };
 

  parent reply	other threads:[~2019-06-24  1:42 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-20  1:33 [PATCH v5 0/5] x86/umwait: Enable user wait instructions Fenghua Yu
2019-06-20  1:33 ` [PATCH v5 1/5] x86/cpufeatures: Enumerate " Fenghua Yu
2019-06-24  0:01   ` [tip:x86/cpu] " tip-bot for Fenghua Yu
2019-06-20  1:33 ` [PATCH v5 2/5] x86/umwait: Initialize umwait control values Fenghua Yu
2019-06-23 22:39   ` Thomas Gleixner
2019-06-24 22:12     ` Fenghua Yu
2019-06-24  0:01   ` [tip:x86/cpu] " tip-bot for Fenghua Yu
2019-06-20  1:33 ` [PATCH v5 3/5] x86/umwait: Add sysfs interface to control umwait C0.2 state Fenghua Yu
2019-06-23 22:40   ` Thomas Gleixner
2019-06-24  0:02   ` [tip:x86/cpu] " tip-bot for Fenghua Yu
2019-06-20  1:33 ` [PATCH v5 4/5] x86/umwait: Add sysfs interface to control umwait maximum time Fenghua Yu
2019-06-23 22:40   ` Thomas Gleixner
2019-06-24  0:03   ` tip-bot for Fenghua Yu [this message]
2019-06-20  1:33 ` [PATCH v5 5/5] x86/umwait: Document umwait control sysfs interfaces Fenghua Yu
2019-06-23 22:42   ` Thomas Gleixner
2019-06-23 22:46     ` Thomas Gleixner
2019-06-24  0:03   ` [tip:x86/cpu] Documentation/ABI: " tip-bot for Fenghua Yu
2019-06-20 16:25 ` [PATCH v5 0/5] x86/umwait: Enable user wait instructions Andy Lutomirski
2019-06-20 23:28   ` Fenghua Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-bd9a0c97e53c3d7a56b2751179903ddc5da42683@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=ashok.raj@intel.com \
    --cc=bp@alien8.de \
    --cc=fenghua.yu@intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=ravi.v.shankar@intel.com \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome