From: "tip-bot for H. Peter Anvin" <hpa@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
sam@ravnborg.org, rdreier@cisco.com, tglx@linutronix.de,
mmarek@sues.cz, mhiramat@redhat.com
Subject: [tip:x86/urgent] Makefile: set LC_CTYPE, LC_COLLATE, LC_NUMERIC to C
Date: Thu, 17 Dec 2009 16:18:35 GMT [thread overview]
Message-ID: <tip-c051346b7db27aaf674b8f3b4955240580b2a58a@git.kernel.org> (raw)
In-Reply-To: <4B2A1761.4070904@suse.cz>
Commit-ID: c051346b7db27aaf674b8f3b4955240580b2a58a
Gitweb: http://git.kernel.org/tip/c051346b7db27aaf674b8f3b4955240580b2a58a
Author: H. Peter Anvin <hpa@zytor.com>
AuthorDate: Thu, 17 Dec 2009 06:56:11 -0800
Committer: H. Peter Anvin <hpa@zytor.com>
CommitDate: Thu, 17 Dec 2009 07:03:21 -0800
Makefile: set LC_CTYPE, LC_COLLATE, LC_NUMERIC to C
There are a number of common Unix constructs like character ranges in
grep/sed/awk which don't work as expected with LC_COLLATE set to other
than C. Similarly, set LC_CTYPE and LC_NUMERIC to C to avoid other
nasty surprises.
In order to make sure these actually take effect we also have to
clear LC_ALL.
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Acked-by: Michal Marek <mmarek@sues.cz>
Acked-by: Masami Hiramatsu <mhiramat@redhat.com>
Acked-by: Roland Dreier <rdreier@cisco.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
LKML-Reference: <4B2A1761.4070904@suse.cz>
---
Makefile | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/Makefile b/Makefile
index 33d4732..6e39af1 100644
--- a/Makefile
+++ b/Makefile
@@ -16,6 +16,13 @@ NAME = Man-Eating Seals of Antiquity
# o print "Entering directory ...";
MAKEFLAGS += -rR --no-print-directory
+# Avoid funny character set dependencies
+LC_ALL=
+LC_CTYPE=C
+LC_COLLATE=C
+LC_NUMERIC=C
+export LC_ALL LC_CTYPE LC_COLLATE LC_NUMERIC
+
# We are using a recursive build, so we need to do a little thinking
# to get the ordering right.
#
next prev parent reply other threads:[~2009-12-17 16:19 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-16 23:56 CONFIG_KPROBES=y build requires gawk Andrew Isaacson
2009-12-17 1:19 ` Al Viro
2009-12-17 3:43 ` Masami Hiramatsu
2009-12-17 4:30 ` Al Viro
2009-12-17 5:16 ` Masami Hiramatsu
2009-12-17 1:39 ` Roland Dreier
2009-12-17 2:43 ` H. Peter Anvin
2009-12-17 3:02 ` Al Viro
2009-12-17 4:09 ` Roland Dreier
2009-12-17 5:07 ` H. Peter Anvin
2009-12-17 5:21 ` Masami Hiramatsu
2009-12-17 5:22 ` H. Peter Anvin
2009-12-17 4:09 ` Rob Landley
2009-12-17 3:33 ` Masami Hiramatsu
2009-12-17 3:45 ` H. Peter Anvin
2009-12-17 4:12 ` Rob Landley
2009-12-17 4:15 ` Roland Dreier
2009-12-17 4:56 ` Masami Hiramatsu
2009-12-17 5:11 ` Roland Dreier
2009-12-17 5:21 ` H. Peter Anvin
2009-12-17 5:43 ` Rob Landley
2009-12-17 5:49 ` Masami Hiramatsu
2009-12-17 5:49 ` H. Peter Anvin
2009-12-17 6:06 ` Masami Hiramatsu
2009-12-17 6:08 ` H. Peter Anvin
2009-12-17 6:20 ` Masami Hiramatsu
2009-12-17 6:26 ` H. Peter Anvin
2009-12-17 6:51 ` Roland Dreier
2009-12-17 13:18 ` Masami Hiramatsu
2009-12-17 5:45 ` Sam Ravnborg
2009-12-17 5:56 ` H. Peter Anvin
2009-12-17 6:17 ` Roland Dreier
2009-12-17 6:23 ` H. Peter Anvin
2009-12-17 7:54 ` Sam Ravnborg
2009-12-17 8:09 ` Sam Ravnborg
2009-12-17 11:34 ` Michal Marek
2009-12-17 16:18 ` tip-bot for H. Peter Anvin [this message]
2009-12-17 22:09 ` [tip:x86/urgent] Makefile: set LC_CTYPE, LC_COLLATE, LC_NUMERIC to C Sam Ravnborg
2009-12-17 22:28 ` H. Peter Anvin
2009-12-17 23:34 ` Masami Hiramatsu
2009-12-17 23:37 ` H. Peter Anvin
2009-12-17 23:41 ` H. Peter Anvin
2009-12-17 23:41 ` Masami Hiramatsu
2009-12-17 23:45 ` H. Peter Anvin
2009-12-17 23:49 ` Masami Hiramatsu
2009-12-17 23:58 ` [tip:x86/urgent] Makefile: Unexport LC_ALL instead of clearing it tip-bot for H. Peter Anvin
2009-12-17 23:40 ` [tip:x86/urgent] Makefile: set LC_CTYPE, LC_COLLATE, LC_NUMERIC to C Roland Dreier
2009-12-17 23:44 ` Masami Hiramatsu
2009-12-17 23:46 ` H. Peter Anvin
2009-12-17 23:54 ` Masami Hiramatsu
2009-12-17 14:50 ` CONFIG_KPROBES=y build requires gawk H. Peter Anvin
2009-12-17 10:42 ` Michal Marek
2009-12-17 13:21 ` Masami Hiramatsu
2009-12-17 16:18 ` [tip:x86/urgent] x86: Don't use POSIX character classes in gen-insn-attr-x86.awk tip-bot for Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-c051346b7db27aaf674b8f3b4955240580b2a58a@git.kernel.org \
--to=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mhiramat@redhat.com \
--cc=mingo@redhat.com \
--cc=mmarek@sues.cz \
--cc=rdreier@cisco.com \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome