From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752107AbdFTNbd (ORCPT ); Tue, 20 Jun 2017 09:31:33 -0400 Received: from terminus.zytor.com ([65.50.211.136]:56463 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751937AbdFTNbb (ORCPT ); Tue, 20 Jun 2017 09:31:31 -0400 Date: Tue, 20 Jun 2017 06:28:00 -0700 From: tip-bot for Dan Carpenter Message-ID: Cc: dzickus@redhat.com, dan.carpenter@oracle.com, peterz@infradead.org, tglx@linutronix.de, mingo@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org Reply-To: peterz@infradead.org, tglx@linutronix.de, mingo@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, dan.carpenter@oracle.com, dzickus@redhat.com In-Reply-To: <20170619105304.GA23995@elgon.mountain> References: <20170619105304.GA23995@elgon.mountain> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/debug] x86/nmi: Fix timeout test in test_nmi_ipi() Git-Commit-ID: c133c7615751008f6c32ccae7cdfc5ff6e989c35 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: c133c7615751008f6c32ccae7cdfc5ff6e989c35 Gitweb: http://git.kernel.org/tip/c133c7615751008f6c32ccae7cdfc5ff6e989c35 Author: Dan Carpenter AuthorDate: Mon, 19 Jun 2017 13:53:04 +0300 Committer: Ingo Molnar CommitDate: Tue, 20 Jun 2017 12:52:43 +0200 x86/nmi: Fix timeout test in test_nmi_ipi() We're supposed to exit the loop with "timeout" set to zero. Signed-off-by: Dan Carpenter Acked-by: Don Zickus Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: kernel-janitors@vger.kernel.org Fixes: 99e8b9ca90d6 ("x86, NMI: Add NMI IPI selftest") Link: http://lkml.kernel.org/r/20170619105304.GA23995@elgon.mountain Signed-off-by: Ingo Molnar --- arch/x86/kernel/nmi_selftest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/nmi_selftest.c b/arch/x86/kernel/nmi_selftest.c index 6d9582e..d27f8d8 100644 --- a/arch/x86/kernel/nmi_selftest.c +++ b/arch/x86/kernel/nmi_selftest.c @@ -78,7 +78,7 @@ static void __init test_nmi_ipi(struct cpumask *mask) /* Don't wait longer than a second */ timeout = USEC_PER_SEC; - while (!cpumask_empty(mask) && timeout--) + while (!cpumask_empty(mask) && --timeout) udelay(1); /* What happens if we timeout, do we still unregister?? */