From: tip-bot for Josh Poimboeuf <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: hpa@zytor.com, peterz@infradead.org, jpoimboe@redhat.com,
torvalds@linux-foundation.org, tglx@linutronix.de,
mingo@kernel.org, fengguang.wu@intel.com,
linux-kernel@vger.kernel.org
Subject: [tip:sched/core] objtool: Add do_task_dead() to global noreturn list
Date: Thu, 22 Sep 2016 22:33:43 -0700 [thread overview]
Message-ID: <tip-c1fad9ef7ed14aad464972e6444e7a3bd5670f26@git.kernel.org> (raw)
In-Reply-To: <20160922212125.zbuewckqll4yur25@treble>
Commit-ID: c1fad9ef7ed14aad464972e6444e7a3bd5670f26
Gitweb: http://git.kernel.org/tip/c1fad9ef7ed14aad464972e6444e7a3bd5670f26
Author: Josh Poimboeuf <jpoimboe@redhat.com>
AuthorDate: Thu, 22 Sep 2016 16:21:25 -0500
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Fri, 23 Sep 2016 07:28:05 +0200
objtool: Add do_task_dead() to global noreturn list
objtool reports the following new warning:
kernel/exit.o: warning: objtool: do_exit() falls through to next function complete_and_exit()
The warning is caused by do_exit()'s new call to do_task_dead(), which
is a new "noreturn" function which objtool doesn't know about yet,
introduced by:
9af6528ee9b6 ("sched/core: Optimize __schedule()")
( objtool has to know all the global noreturn functions so it can follow
the control flow of any functions which call them. Unfortunately they
need to be hard-coded because there's no automated way to detect them. )
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: kbuild-all@01.org
Cc: tipbuild@zytor.com
Link: http://lkml.kernel.org/r/20160922212125.zbuewckqll4yur25@treble
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
tools/objtool/builtin-check.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/objtool/builtin-check.c b/tools/objtool/builtin-check.c
index bd09d0e..143b6cd 100644
--- a/tools/objtool/builtin-check.c
+++ b/tools/objtool/builtin-check.c
@@ -175,6 +175,7 @@ static int __dead_end_function(struct objtool_file *file, struct symbol *func,
"__stack_chk_fail",
"panic",
"do_exit",
+ "do_task_dead",
"__module_put_and_exit",
"complete_and_exit",
"kvm_spurious_fault",
prev parent reply other threads:[~2016-09-23 5:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 18:37 [tip:sched/core 44/47] kernel/exit.o: warning: objtool: do_exit() falls through to next function complete_and_exit() kbuild test robot
2016-09-22 21:21 ` [PATCH] objtool: add do_task_dead() to global noreturn list Josh Poimboeuf
2016-09-23 5:33 ` tip-bot for Josh Poimboeuf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-c1fad9ef7ed14aad464972e6444e7a3bd5670f26@git.kernel.org \
--to=tipbot@zytor.com \
--cc=fengguang.wu@intel.com \
--cc=hpa@zytor.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome