From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933762AbdEOJKS (ORCPT ); Mon, 15 May 2017 05:10:18 -0400 Received: from terminus.zytor.com ([65.50.211.136]:47363 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933664AbdEOJKR (ORCPT ); Mon, 15 May 2017 05:10:17 -0400 Date: Mon, 15 May 2017 02:06:34 -0700 From: tip-bot for Lauro Ramos Venancio Message-ID: Cc: mingo@kernel.org, hpa@zytor.com, lvenanci@redhat.com, tglx@linutronix.de, torvalds@linux-foundation.org, efault@gmx.de, linux-kernel@vger.kernel.org, peterz@infradead.org Reply-To: tglx@linutronix.de, lvenanci@redhat.com, torvalds@linux-foundation.org, hpa@zytor.com, mingo@kernel.org, peterz@infradead.org, linux-kernel@vger.kernel.org, efault@gmx.de In-Reply-To: <1492717903-5195-4-git-send-email-lvenanci@redhat.com> References: <1492717903-5195-4-git-send-email-lvenanci@redhat.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:sched/core] sched/topology: Move comment about asymmetric node setups Git-Commit-ID: c20e1ea4b61c3d99a354d912f2d74822fd2a001d X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: c20e1ea4b61c3d99a354d912f2d74822fd2a001d Gitweb: http://git.kernel.org/tip/c20e1ea4b61c3d99a354d912f2d74822fd2a001d Author: Lauro Ramos Venancio AuthorDate: Thu, 20 Apr 2017 16:51:42 -0300 Committer: Ingo Molnar CommitDate: Mon, 15 May 2017 10:15:27 +0200 sched/topology: Move comment about asymmetric node setups Signed-off-by: Lauro Ramos Venancio Signed-off-by: Peter Zijlstra (Intel) Cc: Linus Torvalds Cc: Mike Galbraith Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: lwang@redhat.com Cc: riel@redhat.com Link: http://lkml.kernel.org/r/1492717903-5195-4-git-send-email-lvenanci@redhat.com Signed-off-by: Ingo Molnar --- kernel/sched/topology.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c index 5a4d9ae..c10f44a 100644 --- a/kernel/sched/topology.c +++ b/kernel/sched/topology.c @@ -495,14 +495,6 @@ enum s_alloc { /* * Build an iteration mask that can exclude certain CPUs from the upwards * domain traversal. - * - * Asymmetric node setups can result in situations where the domain tree is of - * unequal depth, make sure to skip domains that already cover the entire - * range. - * - * In that case build_sched_domains() will have terminated the iteration early - * and our sibling sd spans will be empty. Domains should always include the - * CPU they're built on, so check that. */ static void build_group_mask(struct sched_domain *sd, struct sched_group *sg) { @@ -590,7 +582,16 @@ build_overlap_sched_groups(struct sched_domain *sd, int cpu) sibling = *per_cpu_ptr(sdd->sd, i); - /* See the comment near build_group_mask(). */ + /* + * Asymmetric node setups can result in situations where the + * domain tree is of unequal depth, make sure to skip domains + * that already cover the entire range. + * + * In that case build_sched_domains() will have terminated the + * iteration early and our sibling sd spans will be empty. + * Domains should always include the CPU they're built on, so + * check that. + */ if (!cpumask_test_cpu(i, sched_domain_span(sibling))) continue;