From: tip-bot for Dongsheng Yang <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: acme@redhat.com, linux-kernel@vger.kernel.org, hpa@zytor.com,
mingo@kernel.org, namhyung.kim@lge.com, jolsa@redhat.com,
dsahern@gmail.com, tglx@linutronix.de,
yangds.fnst@cn.fujitsu.com
Subject: [tip:perf/core] perf tools: Do not synthesize the treads of default guest.
Date: Sun, 12 Jan 2014 10:37:32 -0800 [thread overview]
Message-ID: <tip-c239c25a82808ad2cbc795b69e621c4c24f154d6@git.kernel.org> (raw)
In-Reply-To: <e9ddb5dac6f963169657218b12ceb3c2030f54e8.1387572416.git.yangds.fnst@cn.fujitsu.com>
Commit-ID: c239c25a82808ad2cbc795b69e621c4c24f154d6
Gitweb: http://git.kernel.org/tip/c239c25a82808ad2cbc795b69e621c4c24f154d6
Author: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
AuthorDate: Fri, 20 Dec 2013 15:53:00 -0500
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 23 Dec 2013 16:49:51 -0300
perf tools: Do not synthesize the treads of default guest.
As the default guest is designed to handle orphan kernel symboles with
--guestkallsysms and --guestmodules, it has no user space.
So we should skip synthesizing threads if machine is default guest.
Signed-off-by: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung.kim@lge.com>
Link: http://lkml.kernel.org/r/e9ddb5dac6f963169657218b12ceb3c2030f54e8.1387572416.git.yangds.fnst@cn.fujitsu.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/event.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c
index 2905771..45a76c6 100644
--- a/tools/perf/util/event.c
+++ b/tools/perf/util/event.c
@@ -133,6 +133,9 @@ static pid_t perf_event__synthesize_comm(struct perf_tool *tool,
goto out;
}
+ if (machine__is_default_guest(machine))
+ return 0;
+
snprintf(filename, sizeof(filename), "%s/proc/%d/task",
machine->root_dir, pid);
@@ -183,6 +186,9 @@ static int perf_event__synthesize_mmap_events(struct perf_tool *tool,
FILE *fp;
int rc = 0;
+ if (machine__is_default_guest(machine))
+ return 0;
+
snprintf(filename, sizeof(filename), "%s/proc/%d/maps",
machine->root_dir, pid);
@@ -409,6 +415,9 @@ int perf_event__synthesize_threads(struct perf_tool *tool,
if (mmap_event == NULL)
goto out_free_comm;
+ if (machine__is_default_guest(machine))
+ return 0;
+
snprintf(proc_path, sizeof(proc_path), "%s/proc", machine->root_dir);
proc = opendir(proc_path);
next prev parent reply other threads:[~2014-01-12 18:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 20:52 [PATCH 0/7 V2] Add support of user space symboles for guest Dongsheng Yang
2013-12-20 15:02 ` David Ahern
2013-12-30 15:32 ` Dongsheng Yang
2013-12-20 20:52 ` [PATCH 1/7] perf tools: Add support for PERF_RECORD_MISC_GUEST_USER in thread__find_addr_map() Dongsheng Yang
2014-01-12 18:36 ` [tip:perf/core] " tip-bot for Dongsheng Yang
2013-12-20 20:52 ` [PATCH 2/7] perf tools: Find the proc info under machine->root_dir Dongsheng Yang
2014-01-12 18:37 ` [tip:perf/core] perf tools: Find the proc info under machine-> root_dir tip-bot for Dongsheng Yang
2013-12-20 20:52 ` [PATCH 3/7] perf tools: Set event->header.misc to PERF_RECORD_MISC_GUEST_USER if machine is guest Dongsheng Yang
2014-01-12 18:37 ` [tip:perf/core] perf tools: Set event-> header.misc " tip-bot for Dongsheng Yang
2013-12-20 20:52 ` [PATCH 4/7] perf tools: Use machine->pid for tgid if mahicne " Dongsheng Yang
2014-01-12 18:37 ` [tip:perf/core] perf tools: Use machine-> pid for tgid if machine " tip-bot for Dongsheng Yang
2013-12-20 20:53 ` [PATCH 5/7] perf tools: Do not synthesize the treads of default guest Dongsheng Yang
2014-01-12 18:37 ` tip-bot for Dongsheng Yang [this message]
2013-12-20 20:53 ` [PATCH 6/7] perf tools: Add support of user space symbols for guest in perf kvm top Dongsheng Yang
2013-12-20 20:53 ` [PATCH 7/7] perf tools: Add support of user space symbols for guest in perf kvm record Dongsheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-c239c25a82808ad2cbc795b69e621c4c24f154d6@git.kernel.org \
--to=tipbot@zytor.com \
--cc=acme@redhat.com \
--cc=dsahern@gmail.com \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=tglx@linutronix.de \
--cc=yangds.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome