mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tip-bot for Dan Carpenter <dan.carpenter@oracle.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
	efault@gmx.de, peterz@infradead.org, rostedt@goodmis.org,
	tglx@linutronix.de, dan.carpenter@oracle.com
Subject: [tip:sched/core] sched: Fix signedness bug in yield_to()
Date: Tue, 5 Feb 2013 07:23:50 -0800	[thread overview]
Message-ID: <tip-c3c186403c6abd32e719f005f0af950155a9e54d@git.kernel.org> (raw)
In-Reply-To: <20130205113751.GA20521@elgon.mountain>

Commit-ID:  c3c186403c6abd32e719f005f0af950155a9e54d
Gitweb:     http://git.kernel.org/tip/c3c186403c6abd32e719f005f0af950155a9e54d
Author:     Dan Carpenter <dan.carpenter@oracle.com>
AuthorDate: Tue, 5 Feb 2013 14:37:51 +0300
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 5 Feb 2013 12:59:29 +0100

sched: Fix signedness bug in yield_to()

In 7b270f6099 "sched: Bail out of yield_to when source and
target runqueue has one task" we changed this to store -ESRCH so
it needs to be signed.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: kbuild@01.org
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Mike Galbraith <efault@gmx.de>
Link: http://lkml.kernel.org/r/20130205113751.GA20521@elgon.mountain
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 kernel/sched/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 26058d0..c5b089d 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -4371,7 +4371,7 @@ bool __sched yield_to(struct task_struct *p, bool preempt)
 	struct task_struct *curr = current;
 	struct rq *rq, *p_rq;
 	unsigned long flags;
-	bool yielded = 0;
+	int yielded = 0;
 
 	local_irq_save(flags);
 	rq = this_rq();

  reply	other threads:[~2013-02-05 15:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-05 11:37 [patch] sched: " Dan Carpenter
2013-02-05 15:23 ` tip-bot for Dan Carpenter [this message]
2014-05-23 10:20 Dan Carpenter
2014-06-05 14:34 ` [tip:sched/core] sched: Fix " tip-bot for Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-c3c186403c6abd32e719f005f0af950155a9e54d@git.kernel.org \
    --to=dan.carpenter@oracle.com \
    --cc=efault@gmx.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome