From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752827AbcGSHql (ORCPT ); Tue, 19 Jul 2016 03:46:41 -0400 Received: from terminus.zytor.com ([198.137.202.10]:47120 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752373AbcGSHqj (ORCPT ); Tue, 19 Jul 2016 03:46:39 -0400 Date: Tue, 19 Jul 2016 00:45:55 -0700 From: tip-bot for Arnd Bergmann Message-ID: Cc: mingo@kernel.org, arnd@arndb.de, hpa@zytor.com, davem@davemloft.net, gregory.clement@free-electrons.com, rcochran@linutronix.de, linux-kernel@vger.kernel.org, marc.zyngier@arm.com, peterz@infradead.org, tglx@linutronix.de, torvalds@linux-foundation.org, jason@lakedaemon.net, thomas.petazzoni@free-electrons.com Reply-To: marc.zyngier@arm.com, linux-kernel@vger.kernel.org, rcochran@linutronix.de, hpa@zytor.com, davem@davemloft.net, gregory.clement@free-electrons.com, arnd@arndb.de, mingo@kernel.org, thomas.petazzoni@free-electrons.com, tglx@linutronix.de, torvalds@linux-foundation.org, jason@lakedaemon.net, peterz@infradead.org In-Reply-To: <20160718160335.3134412-1-arnd@arndb.de> References: <20160718160335.3134412-1-arnd@arndb.de> To: linux-tip-commits@vger.kernel.org Subject: [tip:smp/hotplug] irqchip/armada: Avoid unused function warnings Git-Commit-ID: c76c15e6f16c1529b524ba2c519c4fcef7a45e16 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: c76c15e6f16c1529b524ba2c519c4fcef7a45e16 Gitweb: http://git.kernel.org/tip/c76c15e6f16c1529b524ba2c519c4fcef7a45e16 Author: Arnd Bergmann AuthorDate: Mon, 18 Jul 2016 18:03:21 +0200 Committer: Ingo Molnar CommitDate: Tue, 19 Jul 2016 09:43:43 +0200 irqchip/armada: Avoid unused function warnings When building with CONFIG_SMP disabled, we get some new harmless warnings: drivers/irqchip/irq-armada-370-xp.c:356:12: error: 'mpic_cascaded_starting_cpu' defined but not used [-Werror=unused-function] static int mpic_cascaded_starting_cpu(unsigned int cpu) ^~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/irqchip/irq-armada-370-xp.c:349:12: error: 'armada_xp_mpic_starting_cpu' defined but not used [-Werror=unused-function] static int armada_xp_mpic_starting_cpu(unsigned int cpu) This moves the unused functions into the #ifdef, as they previously were. Signed-off-by: Arnd Bergmann Acked-by: Jason Cooper Cc: David S. Miller Cc: Gregory CLEMENT Cc: Linus Torvalds Cc: Marc Zyngier Cc: Peter Zijlstra Cc: Richard Cochran Cc: Thomas Gleixner Cc: Thomas Petazzoni Fixes: cb5ff2d245c1 ("irqchip/armada-370-xp: Convert to hotplug state machine") Link: http://lkml.kernel.org/r/20160718160335.3134412-1-arnd@arndb.de Signed-off-by: Ingo Molnar --- drivers/irqchip/irq-armada-370-xp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-armada-370-xp.c b/drivers/irqchip/irq-armada-370-xp.c index e2b8fee..cdef440 100644 --- a/drivers/irqchip/irq-armada-370-xp.c +++ b/drivers/irqchip/irq-armada-370-xp.c @@ -344,7 +344,6 @@ static void armada_mpic_send_doorbell(const struct cpumask *mask, writel((map << 8) | irq, main_int_base + ARMADA_370_XP_SW_TRIG_INT_OFFS); } -#endif static int armada_xp_mpic_starting_cpu(unsigned int cpu) { @@ -359,6 +358,7 @@ static int mpic_cascaded_starting_cpu(unsigned int cpu) enable_percpu_irq(parent_irq, IRQ_TYPE_NONE); return 0; } +#endif static const struct irq_domain_ops armada_370_xp_mpic_irq_ops = { .map = armada_370_xp_mpic_irq_map,