From: Jeremy Fitzhardinge <jeremy@goop.org>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
yinghai@kernel.org, jeremy.fitzhardinge@citrix.com,
jeremy@goop.org, tglx@linutronix.de, mingo@elte.hu
Subject: [tip:x86/setup] x86/dmi: fix dmi_alloc() section mismatches
Date: Mon, 23 Mar 2009 16:39:26 GMT [thread overview]
Message-ID: <tip-c8608d6b58981a58ca4aee8308576666c5f7ab0c@git.kernel.org> (raw)
In-Reply-To: <49C6B23C.2040308@goop.org>
Commit-ID: c8608d6b58981a58ca4aee8308576666c5f7ab0c
Gitweb: http://git.kernel.org/tip/c8608d6b58981a58ca4aee8308576666c5f7ab0c
Author: Jeremy Fitzhardinge <jeremy@goop.org>
AuthorDate: Sun, 22 Mar 2009 14:48:44 -0700
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Mon, 23 Mar 2009 17:20:50 +0100
x86/dmi: fix dmi_alloc() section mismatches
Impact: section mismatch fix
Ingo reports these warnings:
> WARNING: vmlinux.o(.text+0x6a288e): Section mismatch in reference from
> the function dmi_alloc() to the function .init.text:extend_brk()
> The function dmi_alloc() references
> the function __init extend_brk().
> This is often because dmi_alloc lacks a __init annotation or the
> annotation of extend_brk is wrong.
dmi_alloc() is a static inline, and so should be immune to this
kind of error. But force it to be inlined and make it __init
anyway, just to be extra sure.
All of dmi_alloc()'s callers are already __init.
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Cc: Yinghai Lu <yinghai@kernel.org>
LKML-Reference: <49C6B23C.2040308@goop.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/include/asm/dmi.h | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/arch/x86/include/asm/dmi.h b/arch/x86/include/asm/dmi.h
index aa32f7e..fd8f9e2 100644
--- a/arch/x86/include/asm/dmi.h
+++ b/arch/x86/include/asm/dmi.h
@@ -1,10 +1,13 @@
#ifndef _ASM_X86_DMI_H
#define _ASM_X86_DMI_H
+#include <linux/compiler.h>
+#include <linux/init.h>
+
#include <asm/io.h>
#include <asm/setup.h>
-static inline void *dmi_alloc(unsigned len)
+static __always_inline __init void *dmi_alloc(unsigned len)
{
return extend_brk(len, sizeof(int));
}
next prev parent reply other threads:[~2009-03-23 16:40 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-14 23:43 Latest brk patchset H. Peter Anvin
2009-03-15 0:32 ` Jeremy Fitzhardinge
2009-03-15 0:37 ` H. Peter Anvin
2009-03-15 6:09 ` Jeremy Fitzhardinge
2009-03-15 6:29 ` Jeremy Fitzhardinge
2009-03-15 20:38 ` [crash] " Ingo Molnar
2009-03-15 20:42 ` Ingo Molnar
2009-03-15 21:19 ` Jeremy Fitzhardinge
2009-03-15 21:28 ` Ingo Molnar
2009-03-15 23:28 ` Jeremy Fitzhardinge
2009-03-16 8:54 ` Ingo Molnar
2009-03-16 16:12 ` Jeremy Fitzhardinge
2009-03-16 16:56 ` Yinghai Lu
2009-03-16 17:20 ` Jeremy Fitzhardinge
2009-03-16 17:54 ` Jeremy Fitzhardinge
2009-03-16 18:15 ` H. Peter Anvin
2009-03-16 18:17 ` Yinghai Lu
2009-03-16 18:22 ` H. Peter Anvin
2009-03-16 18:31 ` Yinghai Lu
2009-03-16 18:17 ` H. Peter Anvin
2009-03-16 19:25 ` Jeremy Fitzhardinge
2009-03-16 19:34 ` H. Peter Anvin
2009-03-16 19:48 ` Yinghai Lu
2009-03-16 20:00 ` Jeremy Fitzhardinge
2009-03-16 20:26 ` H. Peter Anvin
2009-03-16 20:59 ` Jeremy Fitzhardinge
2009-03-16 21:14 ` H. Peter Anvin
2009-03-16 21:31 ` Jeremy Fitzhardinge
2009-03-16 22:35 ` H. Peter Anvin
2009-03-17 2:26 ` Yinghai Lu
2009-03-17 4:00 ` H. Peter Anvin
2009-03-17 5:07 ` Jeremy Fitzhardinge
2009-03-17 16:04 ` H. Peter Anvin
2009-03-17 19:42 ` Jeremy Fitzhardinge
2009-03-17 19:45 ` H. Peter Anvin
2009-03-17 19:59 ` Jeremy Fitzhardinge
2009-03-17 21:19 ` Yinghai Lu
2009-03-17 21:28 ` Jeremy Fitzhardinge
2009-03-17 19:47 ` Jeremy Fitzhardinge
2009-03-22 15:09 ` Ingo Molnar
2009-03-22 17:12 ` Jeremy Fitzhardinge
2009-03-22 17:22 ` Ingo Molnar
2009-03-22 21:48 ` Jeremy Fitzhardinge
2009-03-23 16:39 ` Jeremy Fitzhardinge [this message]
2009-03-15 1:37 ` H. Peter Anvin
2009-03-15 4:43 ` Yinghai Lu
2009-03-15 4:51 ` H. Peter Anvin
2009-03-15 5:33 ` Yinghai Lu
2009-03-15 6:05 ` Jeremy Fitzhardinge
2009-03-15 6:25 ` Yinghai Lu
2009-03-15 6:03 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-c8608d6b58981a58ca4aee8308576666c5f7ab0c@git.kernel.org \
--to=jeremy@goop.org \
--cc=hpa@zytor.com \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome