mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tip-bot for Stanislav Fomichev <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: acme@redhat.com, linux-kernel@vger.kernel.org, paulus@samba.org,
	mingo@redhat.com, hpa@zytor.com, mingo@kernel.org,
	a.p.zijlstra@chello.nl, namhyung@kernel.org,
	stfomichev@yandex-team.ru, tglx@linutronix.de
Subject: [tip:perf/core] perf timechart: Add support for displaying only tasks related data
Date: Sat, 30 Nov 2013 04:51:43 -0800	[thread overview]
Message-ID: <tip-c87097d39dae1c42a5068e00dd3b76a4162ee0fc@git.kernel.org> (raw)
In-Reply-To: <1383323151-19810-5-git-send-email-stfomichev@yandex-team.ru>

Commit-ID:  c87097d39dae1c42a5068e00dd3b76a4162ee0fc
Gitweb:     http://git.kernel.org/tip/c87097d39dae1c42a5068e00dd3b76a4162ee0fc
Author:     Stanislav Fomichev <stfomichev@yandex-team.ru>
AuthorDate: Fri, 1 Nov 2013 20:25:48 +0400
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Wed, 27 Nov 2013 14:58:37 -0300

perf timechart: Add support for displaying only tasks related data

In order to make SVG smaller and faster to browse add possibility to
switch off power related information with -T switch.

Signed-off-by: Stanislav Fomichev <stfomichev@yandex-team.ru>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1383323151-19810-5-git-send-email-stfomichev@yandex-team.ru
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/Documentation/perf-timechart.txt |  3 +++
 tools/perf/builtin-timechart.c              | 11 ++++++++++-
 2 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/tools/perf/Documentation/perf-timechart.txt b/tools/perf/Documentation/perf-timechart.txt
index 4373144..d844189 100644
--- a/tools/perf/Documentation/perf-timechart.txt
+++ b/tools/perf/Documentation/perf-timechart.txt
@@ -35,6 +35,9 @@ OPTIONS
 -P::
 --power-only::
         Only output the CPU power section of the diagram
+-T::
+--tasks-only::
+        Don't output processor state transitions
 -p::
 --process::
         Select the processes to display, by name or PID
diff --git a/tools/perf/builtin-timechart.c b/tools/perf/builtin-timechart.c
index 6410c9e..b3f175a 100644
--- a/tools/perf/builtin-timechart.c
+++ b/tools/perf/builtin-timechart.c
@@ -51,6 +51,7 @@ static u64		turbo_frequency;
 static u64		first_time, last_time;
 
 static bool		power_only;
+static bool		tasks_only;
 
 
 struct per_pid;
@@ -971,7 +972,8 @@ static void write_svg_file(const char *filename)
 	draw_cpu_usage();
 	if (proc_num)
 		draw_process_bars();
-	draw_c_p_states();
+	if (!tasks_only)
+		draw_c_p_states();
 	if (proc_num)
 		draw_wakeups();
 
@@ -1102,6 +1104,8 @@ int cmd_timechart(int argc, const char **argv,
 	OPT_STRING('o', "output", &output_name, "file", "output file name"),
 	OPT_INTEGER('w', "width", &svg_page_width, "page width"),
 	OPT_BOOLEAN('P', "power-only", &power_only, "output power data only"),
+	OPT_BOOLEAN('T', "tasks-only", &tasks_only,
+		    "output processes data only"),
 	OPT_CALLBACK('p', "process", NULL, "process",
 		      "process selector. Pass a pid or process name.",
 		       parse_process),
@@ -1119,6 +1123,11 @@ int cmd_timechart(int argc, const char **argv,
 	argc = parse_options(argc, argv, options, timechart_usage,
 			PARSE_OPT_STOP_AT_NON_OPTION);
 
+	if (power_only && tasks_only) {
+		pr_err("-P and -T options cannot be used at the same time.\n");
+		return -1;
+	}
+
 	symbol__init();
 
 	if (argc && !strncmp(argv[0], "rec", 3))

  reply	other threads:[~2013-11-30 12:56 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-01 16:25 [PATCH v2 0/7] perf timechart improvements Stanislav Fomichev
2013-11-01 16:25 ` [PATCH 1/7] perf timechart: always try to print at least 15 tasks Stanislav Fomichev
2013-11-30 12:51   ` [tip:perf/core] perf timechart: Always " tip-bot for Stanislav Fomichev
2013-11-01 16:25 ` [PATCH 2/7] perf timechart: add option to limit number of tasks Stanislav Fomichev
2013-11-30 12:51   ` [tip:perf/core] perf timechart: Add " tip-bot for Stanislav Fomichev
2013-11-01 16:25 ` [PATCH 3/7] perf timechart: use proc_num to implement --power-only Stanislav Fomichev
2013-11-30 12:51   ` [tip:perf/core] perf timechart: Use " tip-bot for Stanislav Fomichev
2013-11-01 16:25 ` [PATCH 4/7] perf timechart: add support for displaying only tasks related data Stanislav Fomichev
2013-11-30 12:51   ` tip-bot for Stanislav Fomichev [this message]
2013-11-01 16:25 ` [PATCH 5/7] perf timechart: group figures and add title with details Stanislav Fomichev
2013-11-30 12:51   ` [tip:perf/core] perf timechart: Group " tip-bot for Stanislav Fomichev
2013-11-01 16:25 ` [PATCH 6/7] perf timechart: add support for -P and -T in timechart recording Stanislav Fomichev
2013-11-30 12:52   ` [tip:perf/core] perf timechart: Add " tip-bot for Stanislav Fomichev
2013-11-01 16:25 ` [PATCH 7/7] perf timechart: add backtrace support Stanislav Fomichev
2013-11-30 12:52   ` [tip:perf/core] perf timechart: Add " tip-bot for Stanislav Fomichev
2013-11-05 17:28 ` [PATCH v2 0/7] perf timechart improvements Arnaldo Carvalho de Melo
2013-11-06  8:07   ` Namhyung Kim
2013-11-06 17:48     ` Arnaldo Carvalho de Melo
2013-11-07 15:25       ` Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-c87097d39dae1c42a5068e00dd3b76a4162ee0fc@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=paulus@samba.org \
    --cc=stfomichev@yandex-team.ru \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome