From: tip-bot for Neil Horman <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com, hpa@zytor.com,
mingo@kernel.org, nhorman@tuxdriver.com, tglx@linutronix.de
Subject: [tip:x86/iommu] x86: Adjust irq remapping quirk for older revisions of 5500/5520 chipsets
Date: Wed, 19 Mar 2014 06:00:31 -0700 [thread overview]
Message-ID: <tip-cbceb6904f9d99d068711903fc769b84cf036689@git.kernel.org> (raw)
In-Reply-To: <1394649873-14913-1-git-send-email-nhorman@tuxdriver.com>
Commit-ID: cbceb6904f9d99d068711903fc769b84cf036689
Gitweb: http://git.kernel.org/tip/cbceb6904f9d99d068711903fc769b84cf036689
Author: Neil Horman <nhorman@tuxdriver.com>
AuthorDate: Wed, 12 Mar 2014 14:44:33 -0400
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Wed, 19 Mar 2014 13:57:57 +0100
x86: Adjust irq remapping quirk for older revisions of 5500/5520 chipsets
Commit 03bbcb2e7e2 (iommu/vt-d: add quirk for broken interrupt
remapping on 55XX chipsets) properly disables irq remapping on the
5500/5520 chipsets that don't correctly perform that feature.
However, when I wrote it, I followed the errata sheet linked in that
commit too closely, and explicitly tied the activation of the quirk to
revision 0x13 of the chip, under the assumption that earlier revisions
were not in the field. Recently a system was reported to be suffering
from this remap bug and the quirk hadn't triggered, because the
revision id register read at a lower value that 0x13, so the quirk
test failed improperly. Given this, it seems only prudent to adjust
this quirk so that any revision less than 0x13 has the quirk asserted.
Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: x86@kernel.org
Cc: stable@vger.kernel.org
Link: http://lkml.kernel.org/r/1394649873-14913-1-git-send-email-nhorman@tuxdriver.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
arch/x86/kernel/early-quirks.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
index bc4a088..2237b36 100644
--- a/arch/x86/kernel/early-quirks.c
+++ b/arch/x86/kernel/early-quirks.c
@@ -208,7 +208,7 @@ static void __init intel_remapping_check(int num, int slot, int func)
* and should be flagged as broken. Additionally revisions 0x12
* and 0x22 of device id 0x3405 has this problem.
*/
- if (revision == 0x13)
+ if (revision < 0x13)
set_irq_remapping_broken();
else if ((device == 0x3405) &&
((revision == 0x12) ||
next prev parent reply other threads:[~2014-03-19 13:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 18:44 [PATCH] x86: adjust " Neil Horman
2014-03-12 20:05 ` Neil Horman
2014-03-12 20:07 ` [PATCH v2] " Neil Horman
2014-03-12 22:18 ` Thomas Gleixner
2014-03-13 10:59 ` Neil Horman
2014-03-19 13:00 ` tip-bot for Neil Horman [this message]
2014-03-31 20:09 ` [tip:x86/iommu] x86: Adjust " tip-bot for Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-cbceb6904f9d99d068711903fc769b84cf036689@git.kernel.org \
--to=tipbot@zytor.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=nhorman@tuxdriver.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome