mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "tip-bot for Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, paulmck@linux.vnet.ibm.com,
	hpa@zytor.com, mingo@redhat.com, tglx@linutronix.de,
	mingo@elte.hu
Subject: [tip:core/urgent] rcu: Add control variables to lockdep_rcu_dereference() diagnostics
Date: Thu, 4 Mar 2010 16:32:19 GMT	[thread overview]
Message-ID: <tip-cc5b83a9f884fe8722a275069a5a6fde39988455@git.kernel.org> (raw)
In-Reply-To: <1267631219-8713-4-git-send-email-paulmck@linux.vnet.ibm.com>

Commit-ID:  cc5b83a9f884fe8722a275069a5a6fde39988455
Gitweb:     http://git.kernel.org/tip/cc5b83a9f884fe8722a275069a5a6fde39988455
Author:     Paul E. McKenney <paulmck@linux.vnet.ibm.com>
AuthorDate: Wed, 3 Mar 2010 07:46:59 -0800
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Thu, 4 Mar 2010 12:07:32 +0100

rcu: Add control variables to lockdep_rcu_dereference() diagnostics

Add the values of rcu_scheduler_active() and debug_locks() to
the lockdep_rcu_dereference() output to help diagnose RCU
lockdep splats that occur shortly after the scheduler starts.

Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: laijs@cn.fujitsu.com
Cc: dipankar@in.ibm.com
Cc: mathieu.desnoyers@polymtl.ca
Cc: josh@joshtriplett.org
Cc: dvhltc@us.ibm.com
Cc: niv@us.ibm.com
Cc: peterz@infradead.org
Cc: rostedt@goodmis.org
Cc: Valdis.Kletnieks@vt.edu
Cc: dhowells@redhat.com
LKML-Reference: <1267631219-8713-4-git-send-email-paulmck@linux.vnet.ibm.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 kernel/lockdep.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/kernel/lockdep.c b/kernel/lockdep.c
index 0c30d04..681bc2e 100644
--- a/kernel/lockdep.c
+++ b/kernel/lockdep.c
@@ -3822,6 +3822,7 @@ void lockdep_rcu_dereference(const char *file, const int line)
 	printk("%s:%d invoked rcu_dereference_check() without protection!\n",
 			file, line);
 	printk("\nother info that might help us debug this:\n\n");
+	printk("\nrcu_scheduler_active = %d, debug_locks = %d\n", rcu_scheduler_active, debug_locks);
 	lockdep_print_held_locks(curr);
 	printk("\nstack backtrace:\n");
 	dump_stack();

      reply	other threads:[~2010-03-04 16:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-03 15:46 [PATCH tip/core/rcu 0/4] rcu: suppress RCU lockdep early-boot warnings and fixes Paul E. McKenney
2010-03-03 15:46 ` [PATCH tip/core/rcu 1/4] rcu: use wrapper function instead of exporting tasklist_lock Paul E. McKenney
2010-03-04 16:31   ` [tip:core/urgent] rcu: Use " tip-bot for Paul E. McKenney
2010-03-03 15:46 ` [PATCH tip/core/rcu 2/4] rcu: suppress RCU lockdep warnings during early boot Paul E. McKenney
2010-03-04 11:12   ` Ingo Molnar
2010-03-04 11:44     ` Ingo Molnar
2010-03-04 20:35       ` Paul E. McKenney
2010-03-04 20:36     ` Paul E. McKenney
2010-03-04 16:33   ` [tip:core/urgent] rcu: Suppress " tip-bot for Paul E. McKenney
2010-03-03 15:46 ` [PATCH tip/core/rcu 3/4] rcu: revert 1883c79a: early boot now handled by lockdep-RCU Paul E. McKenney
2010-03-04 16:32   ` [tip:core/urgent] rcu, cgroup: Relax the check in task_subsys_state() as early boot is " tip-bot for Paul E. McKenney
2010-03-03 15:46 ` [PATCH tip/core/rcu 4/4] rcu: add control variables to lockdep_rcu_dereference() diagnostics Paul E. McKenney
2010-03-04 16:32   ` tip-bot for Paul E. McKenney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-cc5b83a9f884fe8722a275069a5a6fde39988455@git.kernel.org \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome