From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751688AbdCRPpW (ORCPT ); Sat, 18 Mar 2017 11:45:22 -0400 Received: from terminus.zytor.com ([65.50.211.136]:35664 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751030AbdCRPoy (ORCPT ); Sat, 18 Mar 2017 11:44:54 -0400 Date: Sat, 18 Mar 2017 04:37:07 -0700 From: tip-bot for Colin Ian King Message-ID: Cc: tglx@linutronix.de, x86@kernel.org, mingo@kernel.org, bp@suse.de, colin.king@canonical.com, hpa@zytor.com, linux-kernel@vger.kernel.org Reply-To: hpa@zytor.com, linux-kernel@vger.kernel.org, bp@suse.de, colin.king@canonical.com, mingo@kernel.org, tglx@linutronix.de, x86@kernel.org In-Reply-To: <20170315171010.17536-1-colin.king@canonical.com> References: <20170315171010.17536-1-colin.king@canonical.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/microcode] x86/microcode/AMD: Remove redundant NULL check on mc Git-Commit-ID: cf8178f78645148dc38b28263b9d3f604148e3a8 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: cf8178f78645148dc38b28263b9d3f604148e3a8 Gitweb: http://git.kernel.org/tip/cf8178f78645148dc38b28263b9d3f604148e3a8 Author: Colin Ian King AuthorDate: Wed, 15 Mar 2017 17:10:10 +0000 Committer: Thomas Gleixner CommitDate: Sat, 18 Mar 2017 12:31:58 +0100 x86/microcode/AMD: Remove redundant NULL check on mc mc is a pointer to the static u8 array amd_ucode_patch and therefore can never be null, so the check is redundant. Remove it. Detected by CoverityScan, CID#1372871 ("Logically Dead Code") Signed-off-by: Colin Ian King Cc: kernel-janitors@vger.kernel.org Cc: x86-ml Link: http://lkml.kernel.org/r/20170315171010.17536-1-colin.king@canonical.com Signed-off-by: Borislav Petkov Signed-off-by: Thomas Gleixner --- arch/x86/kernel/cpu/microcode/amd.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/x86/kernel/cpu/microcode/amd.c b/arch/x86/kernel/cpu/microcode/amd.c index 7889ae4..1d38e53 100644 --- a/arch/x86/kernel/cpu/microcode/amd.c +++ b/arch/x86/kernel/cpu/microcode/amd.c @@ -352,8 +352,6 @@ void reload_ucode_amd(void) u32 rev, dummy; mc = (struct microcode_amd *)amd_ucode_patch; - if (!mc) - return; rdmsr(MSR_AMD64_PATCH_LEVEL, rev, dummy);