From: tip-bot for Aaro Koskinen <aaro.koskinen@nokia.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
fweisbec@gmail.com, aaro.koskinen@nokia.com, tglx@linutronix.de,
mingo@elte.hu
Subject: [tip:core/urgent] panic: Fix panic message visibility by calling bust_spinlocks(0) before dying
Date: Mon, 5 Oct 2009 19:11:26 GMT [thread overview]
Message-ID: <tip-d014e8894dfc523dd9d2f2a17b6dcb94facea810@git.kernel.org> (raw)
In-Reply-To: <1254483680-25578-1-git-send-email-aaro.koskinen@nokia.com>
Commit-ID: d014e8894dfc523dd9d2f2a17b6dcb94facea810
Gitweb: http://git.kernel.org/tip/d014e8894dfc523dd9d2f2a17b6dcb94facea810
Author: Aaro Koskinen <aaro.koskinen@nokia.com>
AuthorDate: Fri, 2 Oct 2009 14:41:20 +0300
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Mon, 5 Oct 2009 21:08:09 +0200
panic: Fix panic message visibility by calling bust_spinlocks(0) before dying
Commit ffd71da4e3f ("panic: decrease oops_in_progress only after
having done the panic") moved bust_spinlocks(0) to the end of the
function, which in practice is never reached.
As a result console_unblank() is not called, and on some systems
the user may not see the panic message.
Move it back up to before the unblanking.
Signed-off-by: Aaro Koskinen <aaro.koskinen@nokia.com>
Reviewed-by: Frederic Weisbecker <fweisbec@gmail.com>
LKML-Reference: <1254483680-25578-1-git-send-email-aaro.koskinen@nokia.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
kernel/panic.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/kernel/panic.c b/kernel/panic.c
index 512ab73..bc4dcb6 100644
--- a/kernel/panic.c
+++ b/kernel/panic.c
@@ -90,6 +90,8 @@ NORET_TYPE void panic(const char * fmt, ...)
atomic_notifier_call_chain(&panic_notifier_list, 0, buf);
+ bust_spinlocks(0);
+
if (!panic_blink)
panic_blink = no_blink;
@@ -136,7 +138,6 @@ NORET_TYPE void panic(const char * fmt, ...)
mdelay(1);
i++;
}
- bust_spinlocks(0);
}
EXPORT_SYMBOL(panic);
prev parent reply other threads:[~2009-10-05 19:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-02 11:41 [PATCH] panic: call " Aaro Koskinen
2009-10-02 12:07 ` Frédéric Weisbecker
2009-10-02 12:34 ` [tip:core/urgent] panic: Fix panic message visibility by calling " tip-bot for Aaro Koskinen
2009-10-05 19:11 ` tip-bot for Aaro Koskinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-d014e8894dfc523dd9d2f2a17b6dcb94facea810@git.kernel.org \
--to=aaro.koskinen@nokia.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome