mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tip-bot for Randy Dunlap <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
	rdunlap@infradead.org, stable@vger.kernel.org,
	tglx@linutronix.de, hpa@linux.intel.com
Subject: [tip:x86/urgent] x86: fix build error and kconfig for ia32_emulation and binfmt
Date: Tue, 18 Jun 2013 17:18:34 -0700	[thread overview]
Message-ID: <tip-d1603990ea626668c78527376d9ec084d634202d@git.kernel.org> (raw)
In-Reply-To: <51C0B614.5000708@infradead.org>

Commit-ID:  d1603990ea626668c78527376d9ec084d634202d
Gitweb:     http://git.kernel.org/tip/d1603990ea626668c78527376d9ec084d634202d
Author:     Randy Dunlap <rdunlap@infradead.org>
AuthorDate: Tue, 18 Jun 2013 12:33:40 -0700
Committer:  H. Peter Anvin <hpa@linux.intel.com>
CommitDate: Tue, 18 Jun 2013 16:20:32 -0500

x86: fix build error and kconfig for ia32_emulation and binfmt

Fix kconfig warning and build errors on x86_64 by selecting BINFMT_ELF
when COMPAT_BINFMT_ELF is being selected.

warning: (IA32_EMULATION) selects COMPAT_BINFMT_ELF which has unmet direct dependencies (COMPAT && BINFMT_ELF)

fs/built-in.o: In function `elf_core_dump':
compat_binfmt_elf.c:(.text+0x3e093): undefined reference to `elf_core_extra_phdrs'
compat_binfmt_elf.c:(.text+0x3ebcd): undefined reference to `elf_core_extra_data_size'
compat_binfmt_elf.c:(.text+0x3eddd): undefined reference to `elf_core_write_extra_phdrs'
compat_binfmt_elf.c:(.text+0x3f004): undefined reference to `elf_core_write_extra_data'

[ hpa: This was sent to me for -next but it is a low risk build fix ]

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Link: http://lkml.kernel.org/r/51C0B614.5000708@infradead.org
Cc: <stable@vger.kernel.org>
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
---
 arch/x86/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 685692c..fe120da 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -2265,6 +2265,7 @@ source "fs/Kconfig.binfmt"
 config IA32_EMULATION
 	bool "IA32 Emulation"
 	depends on X86_64
+	select BINFMT_ELF
 	select COMPAT_BINFMT_ELF
 	select HAVE_UID16
 	---help---

  reply	other threads:[~2013-06-19  0:25 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-17  8:51 linux-next: Tree for Jun 17 Stephen Rothwell
2013-06-17 10:04 ` Geert Uytterhoeven
2013-06-18  0:06   ` Stephen Rothwell
2013-06-17 17:03 ` linux-next: Tree for Jun 17 (x86_pkg_temp_thermal.c) Randy Dunlap
2013-06-17 17:26   ` Srinivas Pandruvada
2013-06-17 17:55     ` [PATCH -next] thermal: fix x86_pkg_temp_thermal.c build and Kconfig Randy Dunlap
2013-06-17 18:09       ` Srinivas Pandruvada
2013-06-17 18:12         ` [PATCH -next v2] " Randy Dunlap
2013-06-17 18:17           ` Borislav Petkov
2013-06-17 18:31             ` Srinivas Pandruvada
2013-06-17 19:27             ` [PATCH -next v3] " Randy Dunlap
2013-06-17 19:45               ` Borislav Petkov
2013-06-17 23:28                 ` Zhang Rui
2013-06-17 17:15 ` linux-next: Tree for Jun 17 (compat_binfmt_elf.c) Randy Dunlap
2013-06-18  0:24   ` Stephen Rothwell
2013-06-18 19:33     ` [PATCH -next] x86: fix build error and kconfig for ia32_emulation and binfmt Randy Dunlap
2013-06-19  0:18       ` tip-bot for Randy Dunlap [this message]
2013-06-17 17:26 ` linux-next: Tree for Jun 17 (media/usb/uvc) Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-d1603990ea626668c78527376d9ec084d634202d@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=hpa@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=stable@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome