From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756255AbcBCKUT (ORCPT ); Wed, 3 Feb 2016 05:20:19 -0500 Received: from terminus.zytor.com ([198.137.202.10]:54800 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755709AbcBCKUO (ORCPT ); Wed, 3 Feb 2016 05:20:14 -0500 Date: Wed, 3 Feb 2016 02:19:14 -0800 From: tip-bot for Wang Nan Message-ID: Cc: ast@kernel.org, will.deacon@arm.com, lizefan@huawei.com, namhyung@kernel.org, linux-kernel@vger.kernel.org, hpa@zytor.com, acme@redhat.com, wangnan0@huawei.com, peterz@infradead.org, hekuang@huawei.com, brendan.d.gregg@gmail.com, mingo@kernel.org, masami.hiramatsu.pt@hitachi.com, tglx@linutronix.de, jolsa@kernel.org, daniel@iogearbox.net Reply-To: wangnan0@huawei.com, acme@redhat.com, peterz@infradead.org, hekuang@huawei.com, will.deacon@arm.com, ast@kernel.org, lizefan@huawei.com, linux-kernel@vger.kernel.org, namhyung@kernel.org, hpa@zytor.com, masami.hiramatsu.pt@hitachi.com, tglx@linutronix.de, jolsa@kernel.org, daniel@iogearbox.net, brendan.d.gregg@gmail.com, mingo@kernel.org In-Reply-To: <1453715801-7732-33-git-send-email-wangnan0@huawei.com> References: <1453715801-7732-33-git-send-email-wangnan0@huawei.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf record: Use OPT_BOOLEAN_SET for buildid cache related options Git-Commit-ID: d2db9a98c3058a45780f7fcd0cc8584858cf6b29 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: d2db9a98c3058a45780f7fcd0cc8584858cf6b29 Gitweb: http://git.kernel.org/tip/d2db9a98c3058a45780f7fcd0cc8584858cf6b29 Author: Wang Nan AuthorDate: Mon, 25 Jan 2016 09:56:19 +0000 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 29 Jan 2016 17:39:07 -0300 perf record: Use OPT_BOOLEAN_SET for buildid cache related options 'perf record' knows whether buildid cache is enabled (via --no-no-buildid-cache) deliberately. Buildid cache can be turned off in some situations. Output switching support needs this feature to turn off buildid cache by default. Signed-off-by: Wang Nan Cc: Alexei Starovoitov Cc: Brendan Gregg Cc: Daniel Borkmann Cc: He Kuang Cc: Jiri Olsa Cc: Li Zefan Cc: Masami Hiramatsu Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Will Deacon Cc: Zefan Li Cc: pi3orama@163.com Link: http://lkml.kernel.org/r/1453715801-7732-33-git-send-email-wangnan0@huawei.com Signed-off-by: He Kuang Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-record.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c index 319712a..0ee0d5c 100644 --- a/tools/perf/builtin-record.c +++ b/tools/perf/builtin-record.c @@ -49,7 +49,9 @@ struct record { const char *progname; int realtime_prio; bool no_buildid; + bool no_buildid_set; bool no_buildid_cache; + bool no_buildid_cache_set; bool buildid_all; unsigned long long samples; }; @@ -1097,10 +1099,12 @@ struct option __record_options[] = { OPT_BOOLEAN('P', "period", &record.opts.period, "Record the sample period"), OPT_BOOLEAN('n', "no-samples", &record.opts.no_samples, "don't sample"), - OPT_BOOLEAN('N', "no-buildid-cache", &record.no_buildid_cache, - "do not update the buildid cache"), - OPT_BOOLEAN('B', "no-buildid", &record.no_buildid, - "do not collect buildids in perf.data"), + OPT_BOOLEAN_SET('N', "no-buildid-cache", &record.no_buildid_cache, + &record.no_buildid_cache_set, + "do not update the buildid cache"), + OPT_BOOLEAN_SET('B', "no-buildid", &record.no_buildid, + &record.no_buildid_set, + "do not collect buildids in perf.data"), OPT_CALLBACK('G', "cgroup", &record.evlist, "name", "monitor event in cgroup name only", parse_cgroups),