From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752769AbbCVKRq (ORCPT ); Sun, 22 Mar 2015 06:17:46 -0400 Received: from terminus.zytor.com ([198.137.202.10]:57398 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751799AbbCVKRn (ORCPT ); Sun, 22 Mar 2015 06:17:43 -0400 Date: Sun, 22 Mar 2015 03:17:03 -0700 From: tip-bot for Arnaldo Carvalho de Melo Message-ID: Cc: jolsa@redhat.com, hpa@zytor.com, eranian@google.com, linux-kernel@vger.kernel.org, fweisbec@gmail.com, dzickus@redhat.com, acme@redhat.com, efault@gmx.de, peterz@infradead.org, tglx@linutronix.de, mingo@kernel.org, dsahern@gmail.com, namhyung@kernel.org, adrian.hunter@intel.com, bp@suse.de Reply-To: jolsa@redhat.com, hpa@zytor.com, eranian@google.com, fweisbec@gmail.com, linux-kernel@vger.kernel.org, acme@redhat.com, dzickus@redhat.com, efault@gmx.de, peterz@infradead.org, tglx@linutronix.de, mingo@kernel.org, namhyung@kernel.org, dsahern@gmail.com, adrian.hunter@intel.com, bp@suse.de To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf hists browser: Indicate which callchain entries are annotated Git-Commit-ID: 70e972788888315851a5c1b4982efbcafcd03b5b X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 70e972788888315851a5c1b4982efbcafcd03b5b Gitweb: http://git.kernel.org/tip/70e972788888315851a5c1b4982efbcafcd03b5b Author: Arnaldo Carvalho de Melo AuthorDate: Thu, 19 Mar 2015 16:07:21 -0300 Committer: Arnaldo Carvalho de Melo CommitDate: Sat, 21 Mar 2015 14:53:37 -0300 perf hists browser: Indicate which callchain entries are annotated Now that we can annotate entries in a callchain, show which ones have an associated symbol and samples, by adding a right arrow just before the symbol name when in verbose mode. To toggle verbose mode press 'V'. Cc: Adrian Hunter Cc: Borislav Petkov Cc: David Ahern Cc: Don Zickus Cc: Frederic Weisbecker Cc: Jiri Olsa Cc: Mike Galbraith Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Stephane Eranian Link: http://lkml.kernel.org/n/tip-d2rf1p3h5gdp7hdl2gf2bozl@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/ui/browsers/hists.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c index cd7350a..995b7a8 100644 --- a/tools/perf/ui/browsers/hists.c +++ b/tools/perf/ui/browsers/hists.c @@ -511,6 +511,7 @@ static void hist_browser__show_callchain_entry(struct hist_browser *browser, { int color, width; char folded_sign = callchain_list__folded(chain); + bool show_annotated = browser->show_dso && chain->ms.sym && symbol__annotation(chain->ms.sym)->src; color = HE_COLORSET_NORMAL; width = browser->b.width - (offset + 2); @@ -523,7 +524,8 @@ static void hist_browser__show_callchain_entry(struct hist_browser *browser, ui_browser__set_color(&browser->b, color); hist_browser__gotorc(browser, row, 0); slsmg_write_nstring(" ", offset); - slsmg_printf("%c ", folded_sign); + slsmg_printf("%c", folded_sign); + ui_browser__write_graph(&browser->b, show_annotated ? SLSMG_RARROW_CHAR : ' '); slsmg_write_nstring(str, width); }