mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tip-bot for Ingo Molnar <mingo@elte.hu>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
	rostedt@goodmis.org, jbaron@redhat.com, tglx@linutronix.de,
	mingo@elte.hu
Subject: [tip:perf/core] jump label: Fix GCC feature check when distcc is used
Date: Fri, 24 Sep 2010 09:02:41 GMT	[thread overview]
Message-ID: <tip-d6dad199a10423ce37b8bfec1f055c380dc4a3d5@git.kernel.org> (raw)
In-Reply-To: <20100923034910.867858597@goodmis.org>

Commit-ID:  d6dad199a10423ce37b8bfec1f055c380dc4a3d5
Gitweb:     http://git.kernel.org/tip/d6dad199a10423ce37b8bfec1f055c380dc4a3d5
Author:     Ingo Molnar <mingo@elte.hu>
AuthorDate: Fri, 24 Sep 2010 09:12:25 +0200
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Fri, 24 Sep 2010 09:12:25 +0200

jump label: Fix GCC feature check when distcc is used

The following build bug occurs on distcc builds:

   CC      arch/x86/kernel/asm-offsets.s
 In file included from include/linux/module.h:24,
                  from include/linux/crypto.h:22,
                  from arch/x86/kernel/asm-offsets_64.c:9,
                  from arch/x86/kernel/asm-offsets.c:5:
 include/trace/events/module.h: In function 'trace_module_load':
 include/trace/events/module.h:18: error: expected '(' before 'goto'
 include/trace/events/module.h:18: error: expected identifier or '*' before '(' token

It triggers because distcc is invoked by turning $CC into "distcc gcc",
but gcc-goto.sh check script was using $1 not $@ to expand parameters.

Cc: Jason Baron <jbaron@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
LKML-Reference: <20100923034910.867858597@goodmis.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 scripts/gcc-goto.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/scripts/gcc-goto.sh b/scripts/gcc-goto.sh
index 8e82424..520d16b 100644
--- a/scripts/gcc-goto.sh
+++ b/scripts/gcc-goto.sh
@@ -2,4 +2,4 @@
 # Test for gcc 'asm goto' suport
 # Copyright (C) 2010, Jason Baron <jbaron@redhat.com>
 
-echo "int main(void) { entry: asm goto (\"\"::::entry); return 0; }" | $1 -x c - -c -o /dev/null >/dev/null 2>&1 && echo "y"
+echo "int main(void) { entry: asm goto (\"\"::::entry); return 0; }" | $@ -x c - -c -o /dev/null >/dev/null 2>&1 && echo "y"

      parent reply	other threads:[~2010-09-24  9:03 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-23  3:49 [GIT PULL] jump label: add jump label code Steven Rostedt
2010-09-23  3:49 ` [PATCH 01/11] jump label: Make dynamic no-op selection available outside of ftrace Steven Rostedt
2010-09-23  3:49 ` [PATCH 02/11] jump label: Make text_poke_early() globally visible Steven Rostedt
2010-09-23  3:49 ` [PATCH 03/11] jump label: Base patch for jump label Steven Rostedt
2010-09-23 14:37   ` Mathieu Desnoyers
2010-09-23 15:39     ` Jason Baron
2010-09-23 15:48       ` Mathieu Desnoyers
2010-09-23 18:40         ` Jason Baron
2010-09-23 18:55           ` Mathieu Desnoyers
2010-09-23 19:08             ` Mathieu Desnoyers
2010-09-23 19:11             ` Jason Baron
2010-09-24  0:44           ` Rusty Russell
2010-09-24 13:54           ` Steven Rostedt
2010-09-24 20:54             ` Mathieu Desnoyers
2010-09-24 21:45               ` Jason Baron
2010-09-23 16:52       ` Steven Rostedt
2010-09-23 17:09         ` Mathieu Desnoyers
2010-09-23  3:49 ` [PATCH 04/11] jump label: Initialize workqueue tracepoints *before* they are registered Steven Rostedt
2010-09-23  3:49 ` [PATCH 05/11] jump label: Add jump_label_text_reserved() to reserve jump points Steven Rostedt
2010-09-23  3:49 ` [PATCH 06/11] jump label: Tracepoint support for jump labels Steven Rostedt
2010-09-23  3:49 ` [PATCH 07/11] jump label: Convert dynamic debug to use " Steven Rostedt
2010-09-23  3:49 ` [PATCH 08/11] jump label: x86 support Steven Rostedt
2010-09-23  3:49 ` [PATCH 09/11] jump label: Add sparc64 support Steven Rostedt
2010-09-23  3:49 ` [PATCH 10/11] jump label: Remove duplicate structure for x86 Steven Rostedt
2010-09-23  3:49 ` [PATCH 11/11] jump label/x86/sparc64: Remove !CC_OPTIMIZE_FOR_SIZE config conditions Steven Rostedt
2010-09-23  4:06 ` [GIT PULL] jump label: add jump label code Steven Rostedt
2010-09-23  6:32   ` Ingo Molnar
2010-09-23 12:42 ` Steven Rostedt
2010-09-24  9:02 ` tip-bot for Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-d6dad199a10423ce37b8bfec1f055c380dc4a3d5@git.kernel.org \
    --to=mingo@elte.hu \
    --cc=hpa@zytor.com \
    --cc=jbaron@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome