mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tip-bot for Maxime Bizon <mbizon@freebox.fr>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
	bigeasy@linutronix.de, tglx@linutronix.de, ffainelli@freebox.fr,
	mbizon@freebox.fr
Subject: [tip:x86/urgent] x86/ce4100: Fix reboot by forcing the reboot method to be KBD
Date: Tue, 30 Oct 2012 05:26:45 -0700	[thread overview]
Message-ID: <tip-d7959916026aaae60e1878ae33c7503b2cc4471d@git.kernel.org> (raw)
In-Reply-To: <1351518020-25556-3-git-send-email-ffainelli@freebox.fr>

Commit-ID:  d7959916026aaae60e1878ae33c7503b2cc4471d
Gitweb:     http://git.kernel.org/tip/d7959916026aaae60e1878ae33c7503b2cc4471d
Author:     Maxime Bizon <mbizon@freebox.fr>
AuthorDate: Mon, 29 Oct 2012 14:40:19 +0100
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 30 Oct 2012 10:16:46 +0100

x86/ce4100: Fix reboot by forcing the reboot method to be KBD

The default reboot is via ACPI for this platform, and the CEFDK
bootloader actually supports this, but will issue a system power
off instead of a real reboot. Setting the reboot method to be
KBD instead of ACPI ensures proper system reboot.

Acked-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Maxime Bizon <mbizon@freebox.fr>
Signed-off-by: Florian Fainelli <ffainelli@freebox.fr>
Cc: rui.zhang@intel.com
Cc: alan@linux.intel.com
Link: http://lkml.kernel.org/r/1351518020-25556-3-git-send-email-ffainelli@freebox.fr
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/platform/ce4100/ce4100.c |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/arch/x86/platform/ce4100/ce4100.c b/arch/x86/platform/ce4100/ce4100.c
index 5de16e3..92525cb 100644
--- a/arch/x86/platform/ce4100/ce4100.c
+++ b/arch/x86/platform/ce4100/ce4100.c
@@ -21,6 +21,7 @@
 #include <asm/i8259.h>
 #include <asm/io.h>
 #include <asm/io_apic.h>
+#include <asm/emergency-restart.h>
 
 static int ce4100_i8042_detect(void)
 {
@@ -151,6 +152,15 @@ void __init x86_ce4100_early_setup(void)
 	x86_init.mpparse.find_smp_config = x86_init_noop;
 	x86_init.pci.init = ce4100_pci_init;
 
+	/*
+	 * By default, the reboot method is ACPI which is supported by the
+	 * CE4100 bootloader CEFDK using FADT.ResetReg Address and ResetValue
+	 * the bootloader will however issue a system power off instead of
+	 * reboot. By using BOOT_KBD we ensure proper system reboot as
+	 * expected.
+	 */
+	reboot_type = BOOT_KBD;
+
 #ifdef CONFIG_X86_IO_APIC
 	x86_init.pci.init_irq = sdv_pci_init;
 	x86_init.mpparse.setup_ioapic_ids = setup_ioapic_ids_from_mpc_nocheck;

  reply	other threads:[~2012-10-30 12:27 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-26  9:05 [PATCH 0/3] x86: ce4100 fixes and improvements Florian Fainelli
2012-10-26  9:05 ` [PATCH 1/3] x86: ce4100: implement pm_poweroff Florian Fainelli
2012-10-26  9:30   ` Ingo Molnar
2012-10-26  9:05 ` [PATCH 2/3] x86: ce4100: force reboot method to be KBD Florian Fainelli
2012-10-26  9:32   ` Ingo Molnar
2012-10-26  9:05 ` [PATCH 3/3] x86: ce4100: fixup PCI configuration register access for devices without interrupts Florian Fainelli
2012-10-26 11:30 ` [PATCH 0/3 v2] x86: ce4100 fixes and improvements Florian Fainelli
2012-10-26 11:30   ` [PATCH 1/3 v2] x86: ce4100: implement pm_poweroff Florian Fainelli
2012-10-26 11:30   ` [PATCH 2/3 v2] x86: ce4100: force reboot method to be KBD Florian Fainelli
2012-10-26 14:58     ` Ingo Molnar
2012-10-26 11:30   ` [PATCH 3/3] x86: ce4100: fixup PCI configuration register access for devices without interrupts Florian Fainelli
2012-10-29 13:40   ` [PATCH 0/3 v3] x86: ce4100 fixes and improvements Florian Fainelli
2012-10-29 13:40     ` [PATCH 1/3 v3] x86: ce4100: implement pm_poweroff Florian Fainelli
2012-10-30 12:25       ` [tip:x86/urgent] x86/ce4100: Fix pm_poweroff tip-bot for Florian Fainelli
2012-10-29 13:40     ` [PATCH 2/3 v3] x86: ce4100: force reboot method to be KBD Florian Fainelli
2012-10-30 12:26       ` tip-bot for Maxime Bizon [this message]
2012-10-29 13:40     ` [PATCH 3/3 v3] x86: ce4100: fixup PCI configuration register access for devices without interrupts Florian Fainelli
2012-10-30 12:27       ` [tip:x86/urgent] x86/ce4100: Fix " tip-bot for Maxime Bizon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-d7959916026aaae60e1878ae33c7503b2cc4471d@git.kernel.org \
    --to=mbizon@freebox.fr \
    --cc=bigeasy@linutronix.de \
    --cc=ffainelli@freebox.fr \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome