From: tip-bot for Jeffy Chen <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: jeffy.chen@rock-chips.com, linux-kernel@vger.kernel.org,
mingo@kernel.org, hpa@zytor.com, tglx@linutronix.de
Subject: [tip:irq/core] genirq: Set irq masked state when initializing irq_desc
Date: Mon, 26 Jun 2017 06:58:14 -0700 [thread overview]
Message-ID: <tip-d829b8fb2431595422289cfc210f0a955a8bec74@git.kernel.org> (raw)
In-Reply-To: <1498476814-12563-1-git-send-email-jeffy.chen@rock-chips.com>
Commit-ID: d829b8fb2431595422289cfc210f0a955a8bec74
Gitweb: http://git.kernel.org/tip/d829b8fb2431595422289cfc210f0a955a8bec74
Author: Jeffy Chen <jeffy.chen@rock-chips.com>
AuthorDate: Mon, 26 Jun 2017 19:33:33 +0800
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Mon, 26 Jun 2017 14:05:41 +0200
genirq: Set irq masked state when initializing irq_desc
The irq default state is set to disabled when allocating irq desc, but the
masked state flag is not set. This is inconsistent vs. the state tracking
logic which is used to prevent unnecessary calls to hardware level irq chip
functions.
Set the masked state flag as well.
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: tfiga@chromium.org
Cc: briannorris@chromium.org
Cc: dianders@chromium.org
Link: http://lkml.kernel.org/r/1498476814-12563-1-git-send-email-jeffy.chen@rock-chips.com
---
kernel/irq/irqdesc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/irq/irqdesc.c b/kernel/irq/irqdesc.c
index 35a95fa..948b50e 100644
--- a/kernel/irq/irqdesc.c
+++ b/kernel/irq/irqdesc.c
@@ -116,6 +116,7 @@ static void desc_set_defaults(unsigned int irq, struct irq_desc *desc, int node,
desc->irq_data.chip_data = NULL;
irq_settings_clr_and_set(desc, ~0, _IRQ_DEFAULT_INIT_FLAGS);
irqd_set(&desc->irq_data, IRQD_IRQ_DISABLED);
+ irqd_set(&desc->irq_data, IRQD_IRQ_MASKED);
desc->handle_irq = handle_bad_irq;
desc->depth = 1;
desc->irq_count = 0;
prev parent reply other threads:[~2017-06-26 13:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-26 11:33 [RFC PATCH v2 1/2] genirq: Set irq masked state by default Jeffy Chen
2017-06-26 11:33 ` [RFC PATCH v2 2/2] genirq: Avoid unnecessary low level irq function calls Jeffy Chen
2017-06-26 13:58 ` [tip:irq/core] " tip-bot for Jeffy Chen
2017-06-26 13:58 ` tip-bot for Jeffy Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-d829b8fb2431595422289cfc210f0a955a8bec74@git.kernel.org \
--to=tipbot@zytor.com \
--cc=hpa@zytor.com \
--cc=jeffy.chen@rock-chips.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®