From: tip-bot for Dan Carpenter <error27@gmail.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
rostedt@goodmis.org, error27@gmail.com, tglx@linutronix.de
Subject: [tip:perf/core] perf: Fix check at end of event search
Date: Fri, 7 May 2010 18:40:42 GMT [thread overview]
Message-ID: <tip-d9f599e1e6d019968b35d2dc63074b9e8964fa69@git.kernel.org> (raw)
In-Reply-To: <20100320143911.GF5331@bicker>
Commit-ID: d9f599e1e6d019968b35d2dc63074b9e8964fa69
Gitweb: http://git.kernel.org/tip/d9f599e1e6d019968b35d2dc63074b9e8964fa69
Author: Dan Carpenter <error27@gmail.com>
AuthorDate: Sat, 20 Mar 2010 17:39:11 +0300
Committer: Steven Rostedt <rostedt@goodmis.org>
CommitDate: Thu, 6 May 2010 19:49:52 -0400
perf: Fix check at end of event search
The original code doesn't work because "call" is never NULL there.
Signed-off-by: Dan Carpenter <error27@gmail.com>
LKML-Reference: <20100320143911.GF5331@bicker>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
kernel/trace/trace_events_filter.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c
index 88c0b6d..58092d8 100644
--- a/kernel/trace/trace_events_filter.c
+++ b/kernel/trace/trace_events_filter.c
@@ -1398,7 +1398,7 @@ int ftrace_profile_set_filter(struct perf_event *event, int event_id,
}
err = -EINVAL;
- if (!call)
+ if (&call->list == &ftrace_events)
goto out_unlock;
err = -EEXIST;
prev parent reply other threads:[~2010-05-07 18:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-20 13:19 [patch] trace: find the correct ftrace event Dan Carpenter
2010-03-20 13:37 ` Steven Rostedt
2010-03-20 13:56 ` Dan Carpenter
2010-03-20 14:07 ` Steven Rostedt
2010-03-20 14:31 ` Dan Carpenter
2010-03-20 14:39 ` [patch v2] " Dan Carpenter
2010-03-21 1:09 ` Steven Rostedt
2010-05-07 18:40 ` tip-bot for Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-d9f599e1e6d019968b35d2dc63074b9e8964fa69@git.kernel.org \
--to=error27@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome